Wireshark-commits, February 2015
- [Wireshark-commits] master a300227: AMQP 0-9-1: Add missing methods connection.block and connection.unblock.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] master ff16cfe: Added nsis generated files to .gitignore,
Wireshark code review
- [Wireshark-commits] master 70912c8: Minor doc update for Wwindows build,
Wireshark code review
- [Wireshark-commits] master 351e7d5: [Automatic manuf, services and enterprise-numbers update for 2015-02-01],
Wireshark code review
- [Wireshark-commits] master-1.12 108ead4: [Automatic manuf, services and enterprise-numbers update for 2015-02-01],
Wireshark code review
- [Wireshark-commits] master-1.10 703eb05: [Automatic manuf, services and enterprise-numbers update for 2015-02-01],
Wireshark code review
- [Wireshark-commits] master 50e8415: rip: Fix "Dissector Bug": register 5 missing hfi_... fields,
Wireshark code review
- [Wireshark-commits] master 17b228b: dlm3: col_...() shouldn't be called under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master-1.12 62f5451: dlm3: col_...() shouldn't be called under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master-1.10 aacc5a7: dlm3: col_...() shouldn't be called under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master 3947091: Fix a typo.,
Wireshark code review
- [Wireshark-commits] master 2cae320: CMake: Build a complete application bundle on OS X.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] master 359ff31: Bluetooth: HCI: Improve detecting of undecoded and unknown commands,
Wireshark code review
- [Wireshark-commits] master c4f08ec: Bluetooth: HCI Vendor: Fix for "Enable WBS" command,
Wireshark code review
- [Wireshark-commits] master ef6f6f0: Bluetooth: AVCTP: Improve IPID handling,
Wireshark code review
- [Wireshark-commits] master 578c2be: Bluetooth: btle_rf: Use proto_tree_add_bitmask,
Wireshark code review
- [Wireshark-commits] master 1786cfe: Bluetooth: Advertising Data: Fix Service Data entry,
Wireshark code review
- [Wireshark-commits] master 6521771: Bluetooth: Simplify to "UnknownDirection" in Info column when direction is unknown,
Wireshark code review
- [Wireshark-commits] master 003e337: Fix some indent typo (after g2bf7878e),
Wireshark code review
- [Wireshark-commits] master bdaef53: Try to fix builbot OSX 10.5 buildbot false-positive,
Wireshark code review
- [Wireshark-commits] master 6db0a35: Create wmem versions of val_to_str and val_to_str_ext,
Wireshark code review
- [Wireshark-commits] master e102c34: Minor doc changes for Windows build,
Wireshark code review
- [Wireshark-commits] master 9f4bf6a: LTE RRC: only display band mapping for the initial supportedBandListEUTRA IE,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz Test,
buildbot-no-reply
- [Wireshark-commits] master c96b3ac: AMQP 0-9-1: Fix dissection of field types.,
Wireshark code review
- [Wireshark-commits] master 0b2c8b0: AMQP: fix declaration of 'index' shadows a global declaration,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- <Possible follow-ups>
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] master 37a2cd0: AMQP: fix declaration of 'index' shadows a global declaration,
Wireshark code review
- [Wireshark-commits] master 71fd34d: WSUG: Chocolatey updates.,
Wireshark code review
- [Wireshark-commits] master-1.12 c73bab0: README.dissector: fixed p_add_proto_data params,
Wireshark code review
- [Wireshark-commits] master ec618b5: HTTP2: Fix offset for heuristic,
Wireshark code review
- [Wireshark-commits] master 383caa7: AMQP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 9d7f5c7: ISIS: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 00f7bc4: Qt: Fix IO Graph capture file closing.,
Wireshark code review
- [Wireshark-commits] master 33f1256: Fix nameless application in NokiaSolutionsAndNetworks.xml (from I4cd9bd7f7219e4d9ff1bb8a71fab32439a8a9a35).,
Wireshark code review
- [Wireshark-commits] master 8ba3d6f: Bluetooth: ATT: Dissect GATT level,
Wireshark code review
- [Wireshark-commits] master 73579dd: Bluetooth: ATT: Dissection stage 3: Assign UUID to Handle,
Wireshark code review
- [Wireshark-commits] master db068ff: Bluetooth: ATT: Decode some HOGP attributes,
Wireshark code review
- [Wireshark-commits] master 60b9be9: Bluetooth: ATT: Dissect Read Multiple Response,
Wireshark code review
- [Wireshark-commits] master ca3fe28: Bluetooth: ATT: Dissect almost all attributes,
Wireshark code review
- [Wireshark-commits] master 8417fbf: Initialize the entire UUID.,
Wireshark code review
- [Wireshark-commits] master e942973: Bluetooth/USB HID: Move boot form of reports from bthid to usbhid,
Wireshark code review
- [Wireshark-commits] master b635997: Convert val_to_str_ext -> val_to_str_ext_wmem for calls that don't have valid packet scope (GUI). val_to_str_ext now officially uses wmem_packet_scope().,
Wireshark code review
- [Wireshark-commits] master a2eec54: BT ATT: Fix what appears to be a value string mismatch.,
Wireshark code review
- [Wireshark-commits] master 33bdb21c: xtp: Don't call col_...() under 'if (tree)',
Wireshark code review
- [Wireshark-commits] master 9b22a2f: Updates in it translation.,
Wireshark code review
- [Wireshark-commits] master b8f040c: Dumpcap: avoid collecting stats on nf* interfaces.,
Wireshark code review
- [Wireshark-commits] master deabe64: Don't build app_bundle by default.,
Wireshark code review
- [Wireshark-commits] master 0e74e8b: Decorate declarations with G_GNUC_PRINTF() as appropriate.,
Wireshark code review
- [Wireshark-commits] master 4fe8ca0: Simplify how we find Lua and expand the places we look.,
Wireshark code review
- [Wireshark-commits] master 342ba90: Minor WSDG updates.,
Wireshark code review
- [Wireshark-commits] master 89e6f4c: Qt: Add the Protocol Hierarchy statistics dialog.,
Wireshark code review
- [Wireshark-commits] master 9e1ddb5: Only set HAVE_LUA if we, er, have Lua.,
Wireshark code review
- [Wireshark-commits] master 66fc81b: SEL Protocol Maintenance (1/2),
Wireshark code review
- [Wireshark-commits] master 18bc353: MySQL: Add support of AuthSwitchRequest/AuthSwitchResponse,
Wireshark code review
- [Wireshark-commits] master c256bbe: MySQL: Use proto_tree_add_bitmask(with_flags),
Wireshark code review
- [Wireshark-commits] master 74547db: MySQL: Add Server ext caps and Auth Plugin Length to Server Greeting,
Wireshark code review
- [Wireshark-commits] master 90a76e0: Convert val_to_str -> val_to_str_wmem.,
Wireshark code review
- [Wireshark-commits] master 7ced085: emem is dead! Long live wmem!,
Wireshark code review
- [Wireshark-commits] master bee4fb0: CAPWAP: Use proto_tree_add_bitmask(_with_flags),
Wireshark code review
- [Wireshark-commits] master 8efe6b7: RADIUS: Sync with FreeRADIUS Master,
Wireshark code review
- [Wireshark-commits] master ef929ad: TOS-specific forwarding blocks aren't actually required: don't warn when they aren't present. Only warn if no forwarding blocks are present.,
Wireshark code review
- [Wireshark-commits] master 0f353c9: HTTP2: Add tap for HTTP2 dissector,
Wireshark code review
- [Wireshark-commits] master f2cb59a: Add QNX' QNET protocol,
Wireshark code review
- [Wireshark-commits] master 9f78bf6: Use QNX_PC_ for QNX's pathconf parameter values.,
Wireshark code review
- [Wireshark-commits] master 94011c1: [QNET6] Try to fix solaris buildboot. /Users/buildslave/Documents/wireshark/osx105x86/build/epan/dissectors/packet-qnet6.c:1502: warning: 'hf_index' may be used uninitialized in this function /Users/buildslave/Documents/wireshark/osx105x86/build/epan/dissectors/packet-qnet6.c:1502: note: 'hf_index' was declared here /Users/buildslave/Documents/wireshark/osx105x86/build/epan/dissectors/packet-qnet6.c:1502: warning: 'hf_index_off' may be used uninitialized in this function /Users/buildslave/Documents/wireshark/osx105x86/build/epan/dissectors/packet-qnet6.c:1502: note: 'hf_index_off' was declared here /Users/buildslave/Documents/wireshark/osx105x86/build/epan/dissectors/packet-qnet6.c:1500: warning: 'sstree' may be used uninitialized in this function /Users/buildslave/Documents/wireshark/osx105x86/build/epan/dissectors/packet-qnet6.c:1500: note: 'sstree' was declared here /Users/buildslave/Documents/wireshark/osx105x86/build/epan/dissectors/packet-qnet6.c:1502: warning: 'hf_index_len' may be used uninitialized in this function /Users/buildslave/Documents/wireshark/osx105x86/build/epan/dissectors/packet-qnet6.c:1502: note: 'hf_index_len' was declared here,
Wireshark code review
- [Wireshark-commits] master 9875181: [CAMEL] Dissect additionalCallingPartyNumber. Ping-Bug: 10914 Change-Id: I28eb9d7b5192a02f82fe604d20e57aedd706f528 Reviewed-on: https://code.wireshark.org/review/6946 Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>,
Wireshark code review
- [Wireshark-commits] master 0a6d1f9: Support for P3 over RTSE.,
Wireshark code review
- [Wireshark-commits] master d9e82b7: [INAP] Add dissection of Cause Ping-Bug:10910 Change-Id: I131d81b0d6332cc72e7b32dc81cb7fec4ca3d407 Reviewed-on: https://code.wireshark.org/review/6947 Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>,
Wireshark code review
- [Wireshark-commits] master 150dd22: [INAP] Make INAP a new style dissector and add an OID dissector for 0.4.0.1.1.1.0.0 cs1-ssp-to-scp.,
Wireshark code review
- [Wireshark-commits] master febc842: Update README.wmem, release notes for emem removal,
Wireshark code review
- [Wireshark-commits] master a8cc331: Update the release notes.,
Wireshark code review
- [Wireshark-commits] master a748e83: Qt: Add "Copy As..." to the Protocol Hierarchy stats.,
Wireshark code review
- [Wireshark-commits] master b2db3bf: Build 1.99.2.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.99.2 created (now a11f0bb),
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag wireshark-1.99.2 created (now 29726e4),
Wireshark code review
- [Wireshark-commits] master 52b4059: 1.99.2 → 1.99.3.,
Wireshark code review
- [Wireshark-commits] [wireshark] annotated tag v1.99.3rc0 created (now 65ea0f5),
Wireshark code review
- [Wireshark-commits] master 40d06bd: Don't clobber PROJECT_VERSION_EXTENSION.,
Wireshark code review
- [Wireshark-commits] master 86d24b0: LPP: upgrade dissector to v12.3.0,
Wireshark code review
- [Wireshark-commits] master a2e48c6: On OS X, temporarily use cp to install some files.,
Wireshark code review
- [Wireshark-commits] master 5b62526: OK, try cmake -E copy.,
Wireshark code review
- [Wireshark-commits] master 8ffaec9: CAPWAP: Don't try to dissect fragment packet (Only display are "Data"),
Wireshark code review
- [Wireshark-commits] master 8bad9ed: CAPWAP : fix warning about wrong type after proto_tree_add_bitmask(_with_flags) change,
Wireshark code review
- [Wireshark-commits] master 2bcd38f: ethercat: add default case in FoeFormatter,
Wireshark code review
- [Wireshark-commits] master fb9dc13: MySQL: fix assert when the Connect Attrs capability is set, but no attributes,
Wireshark code review
- [Wireshark-commits] master 48aa669: CAPWAP: Fix a typo.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis,
buildbot-no-reply
- [Wireshark-commits] master dff82e6: Update the Windows build documentation with some common traps that stop people from building as well as a hint about downloading the vcredist_xYY.exe file.,
Wireshark code review
- [Wireshark-commits] master 410a8d1: CMake: Make copy_data_files depend on html_docs.,
Wireshark code review
- [Wireshark-commits] master d138011: WSDG: Fixup admonition block formatting.,
Wireshark code review
- [Wireshark-commits] master 572b30a: Get rid of the temporary OS X-specific hack.,
Wireshark code review
- [Wireshark-commits] master 99761aa: Remove endif() left over from previous change.,
Wireshark code review
- [Wireshark-commits] master 3f480c6: The 'mbrtu' dissector should be registered with RTAC Serial, not the 'modbus' one.,
Wireshark code review
- [Wireshark-commits] master 1fdc6f4: QNX6: avoid deferencing a null pointer,
Wireshark code review
- [Wireshark-commits] master b3e8269: SEL Protocol Maintenance (2/2),
Wireshark code review
- [Wireshark-commits] master 3badc30: QNET6: do not use col_set_str with non constant strings,
Wireshark code review
- [Wireshark-commits] master 61e3bdc: WSDG: Wrap a line.,
Wireshark code review
- [Wireshark-commits] master d6ebb82: (Trivial) Reformat some.,
Wireshark code review
- [Wireshark-commits] master 881ff5d: Remove gethostbyaddr and gethostbyaddr2.,
Wireshark code review
- [Wireshark-commits] master 0b0f7fa: More emem removal.,
Wireshark code review
- [Wireshark-commits] master eb85555: AMQP: Add more COL_INFO description for some packets/frames.,
Wireshark code review
- [Wireshark-commits] master 55eb35a: AMQP: Fix one warning from Clang Code Analysis,
Wireshark code review
- [Wireshark-commits] master 8b095bc: Multicast Stream (GTK): fix crash when try to select a stream,
Wireshark code review
- [Wireshark-commits] master 501d996: Further simplify the LSA-Update processing: the always-present forwarding block can be considered TOS 0.,
Wireshark code review
- [Wireshark-commits] master 49c27d3: cfdp: Fix bug ("Labeled code is unreachable"),
Wireshark code review
- [Wireshark-commits] master-1.12 baff3a3: cfdp: Fix bug ("Labeled code is unreachable"),
Wireshark code review
- [Wireshark-commits] master ff6d503: qnet6: Cleanup,
Wireshark code review
- [Wireshark-commits] master 3b3ce87: qnet6: Fix a bug found by MSVC2013 Code Analysis.,
Wireshark code review
- [Wireshark-commits] master b3f3dd8: Qt: Fix preference change behavior.,
Wireshark code review
- [Wireshark-commits] master c8cad99: Qt: Add the Coloring Rules dialog.,
Wireshark code review
- [Wireshark-commits] master 6f22eb6: Qt: Fix coloring rules reordering.,
Wireshark code review
- [Wireshark-commits] master 2c65b33: Fix RTP crash on RTP analysis attempt,
Wireshark code review
- [Wireshark-commits] master 1ecd0ad: Bluetooth: ATT: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 1eec034: Bluetooth: ATT: Missing break in switch (CID 1268199),
Wireshark code review
- [Wireshark-commits] master 7610a69: Bluetooth: ATT: Fix not missing break,
Wireshark code review
- [Wireshark-commits] master 2ff79dd: Bluetooth: ATT: Fix Running Walking Sensor field name,
Wireshark code review
- [Wireshark-commits] master fb00452: Bluetooth/GUI: ATT: Add Server Attribute Table,
Wireshark code review
- [Wireshark-commits] master 722ce56: btatt: fix bug ("Labeled code is unreachable");,
Wireshark code review
- [Wireshark-commits] master 617c733: Add proto_tree_add_new_bytes(),
Wireshark code review
- [Wireshark-commits] master 13f6bce: Bluetooth: ATT: Use proto_tree_add_new_bytes for UUID128,
Wireshark code review
- [Wireshark-commits] master 1648d6e: new function is_usb_standard_setup_request() to check if a request is a standard setup request,
Wireshark code review
- [Wireshark-commits] master a097659: change try_dissect_next_protocol() such that its parameter is the top-most tree on which it operates,
Wireshark code review
- [Wireshark-commits] master 5403478: refactor the dissection of USB setup requests,
Wireshark code review
- [Wireshark-commits] master 8bf6516: dissect a get descriptor request and response for the HID report descriptor,
Wireshark code review
- [Wireshark-commits] master-1.12 b63b257: DNS NXT RR is parsed incorrectly,
Wireshark code review
- [Wireshark-commits] master 1a5b5fa: remove the offset parameter from dissect_usb_standard_setup_request(),
Wireshark code review
- [Wireshark-commits] master 5457865: use the value string for HID descriptor type,
Wireshark code review
- [Wireshark-commits] master 4282304: set protocol to USBHID for get descriptor request and response if they're dealing with HID descriptors,
Wireshark code review
- [Wireshark-commits] master 6dd1296: WSUG: Update the Packet Colorization section.,
Wireshark code review
- [Wireshark-commits] master 22b4619: Add the profile name to the Coloring Rules window title.,
Wireshark code review
- [Wireshark-commits] master-1.12 5a03e8d: MIPv6: Mobility Header Link Layer Address is parsed incorrectly,
Wireshark code review
- [Wireshark-commits] master 96527e2: riemann: Fix bug found by MSVC203 Code Analysis,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] master 3066d6b: Don't call the Bluetooth code's UUID type "uuid_t".,
Wireshark code review
- [Wireshark-commits] master f494abd: qnet6: don't calculate crc if length is negative,
Wireshark code review
- [Wireshark-commits] master 14c37af: dwarf: fix bug found by MSVC2013 Code Analysis,
Wireshark code review
- [Wireshark-commits] master-1.12 d454818: dwarf: fix bug found by MSVC2013 Code Analysis,
Wireshark code review
- [Wireshark-commits] master 4c1c76a: [Automatic manuf, services and enterprise-numbers update for 2015-02-08],
Wireshark code review
- [Wireshark-commits] master-1.12 f5232d6: [Automatic manuf, services and enterprise-numbers update for 2015-02-08],
Wireshark code review
- [Wireshark-commits] master-1.10 3cb88f8: [Automatic manuf, services and enterprise-numbers update for 2015-02-08],
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Ubuntu 14.04 x64,
buildbot-no-reply
- [Wireshark-commits] master 3b6998d: riemann: Minor cleanup,
Wireshark code review
- [Wireshark-commits] master d7ee095: [ZVT] start dissecting the registration apdu,
Wireshark code review
- [Wireshark-commits] master 0310132: Multicast Stream: Move mcast_stream.[ch] to ui,
Wireshark code review
- [Wireshark-commits] master 3c10841: USB HID: fix no previous prototype for 'dissect_usb_hid_get_report_descriptor' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 58f8076: Menubar (GTK): fix warning: no previous prototype for ‘set_menus_capture_start_sensitivity’ [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 0a2832c: WMEM (allocator): fix warning: redeclaration of already-defined enum '_wmem_allocator_type_t' is a GNU extension [-Wgnu-redeclared-enum],
Wireshark code review
- [Wireshark-commits] master 3b81c36: DNS: LOC Precision missing units,
Wireshark code review
- [Wireshark-commits] master-1.12 8b33b38: DNS: LOC Precision missing units,
Wireshark code review
- [Wireshark-commits] master 4497bb4: Add address type registration.,
Wireshark code review
- [Wireshark-commits] master 2042385: Add "column filter string" support to address types.,
Wireshark code review
- [Wireshark-commits] master 2875cd3: Eliminate the hf member out of the address structure.,
Wireshark code review
- [Wireshark-commits] master 8ff944d: Add fixed length function for address types.,
Wireshark code review
- [Wireshark-commits] master d56a3c9: This adds support for P_DATA_V2 OpenVPN packets.,
Wireshark code review
- [Wireshark-commits] master 702618f: Fix use-after free in RTP player,
Wireshark code review
- [Wireshark-commits] master 3222cd1: ssl-utils: use ALPN hint for improved spdy/http2 recognition,
Wireshark code review
- [Wireshark-commits] master 5b2a05c: [IS-IS LSP] Add support for Adj-SID & LAN-Adj-SID subTLV,
Wireshark code review
- [Wireshark-commits] master 93ed726: ssl, dtls, ssl-utils: Prepare for STARTTLS handling,
Wireshark code review
- [Wireshark-commits] master e190253: Fix STARTTLS handling in various dissectors,
Wireshark code review
- [Wireshark-commits] master 929a4f2: ldap: simplify Start TLS handling,
Wireshark code review
- [Wireshark-commits] master e36a2ad: Netflow: rework how transport (port) resolution is done, adding support for SCTP,
Wireshark code review
- [Wireshark-commits] master a58cf52: file-jpeg: Allow 'Exif' as identification in first App block, but flag as expert info warning if seen,
Wireshark code review
- [Wireshark-commits] master 2078a95: pgsql, imap: add STARTTLS support,
Wireshark code review
- [Wireshark-commits] master e88a11f: (Trivial) Fix printf-related 'Mismatch on sign' warnings,
Wireshark code review
- [Wireshark-commits] master 895b013: Use G_GINT64_MODIFIER when formatting g{u}int64 values.,
Wireshark code review
- [Wireshark-commits] master 3b29542: Add a "Sum" column to the Service Response Time (SRT) window.,
Wireshark code review
- [Wireshark-commits] master 29be26c: FTAM: get rid of an evil global variable,
Wireshark code review
- [Wireshark-commits] master-1.12 268fd52: FTAM: get rid of an evil global variable,
Wireshark code review
- [Wireshark-commits] master 7369c25: IMAP: do not iterate over reported length when using tvb_find_line_end,
Wireshark code review
- [Wireshark-commits] master-1.10 21d146c: FTAM: get rid of an evil global variable,
Wireshark code review
- [Wireshark-commits] master e915db7: Do not iterate over reported length when using tvb_find_line_end,
Wireshark code review
- [Wireshark-commits] master-1.12 f651c8d: Do not iterate over reported length when using tvb_find_line_end,
Wireshark code review
- [Wireshark-commits] master d5f0df4: Add script to automatically remove includes that appear not be needed,
Wireshark code review
- [Wireshark-commits] master 88d62df: Remove unneeded includes from plugins folder,
Wireshark code review
- [Wireshark-commits] master c34ded4: Qt/C++: Change a bunch of includes to forward declarations.,
Wireshark code review
- [Wireshark-commits] master a618f1c: USB: put back interface class when dissecting URB_CONTROL,
Wireshark code review
- [Wireshark-commits] master a837570: Combine SSE and pre-compiled patterns for faster pbrk,
Wireshark code review
- [Wireshark-commits] master a822d85: Try to fix the debian symbols,
Wireshark code review
- [Wireshark-commits] master 9db51df: Remove address_to_str_buf from hsrp dissector "heuristics" as its much faster to just compare the IPv4 address as a 32-bit value.,
Wireshark code review
- [Wireshark-commits] master 3c9c9bc: capture_dlg.c: Fix (possibly valid) "Using uninitialized memory" MSVC2013 Code Analysis warning,
Wireshark code review
- [Wireshark-commits] master 0cd2582: Prevent two false positive MSVC2013 Code Analysis warnings,
Wireshark code review
- [Wireshark-commits] master 0dbf741: packet-iec104: fix packet information text,
Wireshark code review
- [Wireshark-commits] master d3d0a0a: Fix SSE 4.2 checks.,
Wireshark code review
- [Wireshark-commits] master 297ef07: "Hide" hashether_t structure.,
Wireshark code review
- [Wireshark-commits] master 797ea88: Make get_manuf_name return a const string.,
Wireshark code review
- [Wireshark-commits] master 53228c4: Revert "Make get_manuf_name return a const string.",
Wireshark code review
- [Wireshark-commits] master 4359cb8: Revert ""Hide" hashether_t structure.",
Wireshark code review
- [Wireshark-commits] master 7075223: Little tuning of proto_tree_add_bytes_with_length,
Wireshark code review
- [Wireshark-commits] master 207b52a: tvb_length is a macro wrapper for tvb_captured_length; use tvbuff_length.,
Wireshark code review
- [Wireshark-commits] master 60cc8b4: Support for looking for incomplete dissectors.,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis,
buildbot-no-reply
- [Wireshark-commits] master 34acb73: [IS-IS-LSP] Add support for Prefix-SID subTLV,
Wireshark code review
- [Wireshark-commits] master 7594d96: nmake: Allow Cygwin path to be provided,
Wireshark code review
- [Wireshark-commits] master ef21740: Gryphon: do not use col_set_str with non constant strings,
Wireshark code review
- [Wireshark-commits] master-1.12 56a5143: Gryphon: do not use col_set_str with non constant strings,
Wireshark code review
- [Wireshark-commits] master-1.10 bb9bd6b: Gryphon: do not use col_set_str with non constant strings,
Wireshark code review
- [Wireshark-commits] master 678a9b6: BT ATT: memory given to add_new_data_source() must be allocated in pinfo scope,
Wireshark code review
- [Wireshark-commits] master bdcac17: Fix crash at startup in SSE4.2 code when running a 32 bits Windows build,
Wireshark code review
- [Wireshark-commits] master d2aa2c6: WSDG: Start adding Qt material.,
Wireshark code review
- [Wireshark-commits] master b3e2c56: Docbook: Don't build PDF release notes by default.,
Wireshark code review
- [Wireshark-commits] master 931807e: Qt: Add the "new packet" window^Wdialog^Wwindow.,
Wireshark code review
- [Wireshark-commits] master f1d1354: Try to fix compilation on OS X.,
Wireshark code review
- [Wireshark-commits] master a5652c7: Qt: ElidedLabel doesn't support rich text / HTML.,
Wireshark code review
- [Wireshark-commits] master 6e88978: Qt: More #include → forward declarations.,
Wireshark code review
- [Wireshark-commits] master a0498f1: Qt: Double clicking a packet opens the packet window.,
Wireshark code review
- [Wireshark-commits] master 80342e4: Qt: Make WiresharkDialog act like a window.,
Wireshark code review
- [Wireshark-commits] master f0b4b72: Qt: Revert g6e88978 for main_status_bar.,
Wireshark code review
- [Wireshark-commits] master 91a6e5e: Italian translation update,
Wireshark code review
- [Wireshark-commits] master c1610c7: Micro optimization, only do tvb_get_ptr() once for dst and src respectivly.,
Wireshark code review
- [Wireshark-commits] master 48a95de: Register the Mongo dissector by name so it can be used with TLS.,
Wireshark code review
- [Wireshark-commits] master 8843606: Qt: Try to make some dialogs behave like windows.,
Wireshark code review
- [Wireshark-commits] master 4d5bdf4: A dissector for the RSVD Protocol (see [MS-RSVD].pdf).,
Wireshark code review
- [Wireshark-commits] master 936f685: Qt: Allow shift-double-clicking on a frame link.,
Wireshark code review
- [Wireshark-commits] master 9c866ff: Replace tabs by spaces when editor modelines has "expandtab",
Wireshark code review
- [Wireshark-commits] master 82f081d: wslua*: Add editor modelines; Fix indentation, etc as needed.,
Wireshark code review
- [Wireshark-commits] master 6040bcd: caputils/*.c: As needed: Add editor modelines & Fix indentation,
Wireshark code review
- [Wireshark-commits] master 3e3fc9f: epan/dfilter/*.c: As needed: Add editor modelines & Fix indentation,
Wireshark code review
- [Wireshark-commits] master f85d1c8: WSUG: Add a note about dialogs vs windows.,
Wireshark code review
- [Wireshark-commits] master b5a3b65: Qt: Fix side effects of recent WiresharkDialog changes.,
Wireshark code review
- [Wireshark-commits] master f623537: We use GLib's directory-reading routines, so we don't need <dire[cn]t.h>.,
Wireshark code review
- [Wireshark-commits] master a64fc6c: Don't check for C89 headers.,
Wireshark code review
- [Wireshark-commits] master 91b5042: "Hide" hashether_t structure.,
Wireshark code review
- [Wireshark-commits] master 847f590: MIP6: AUTH mobility option parses Mobility SPI and Authentication Data incorrectly,
Wireshark code review
- [Wireshark-commits] master-1.12 0277920: MIP6: AUTH mobility option parses Mobility SPI and Authentication Data incorrectly,
Wireshark code review
- [Wireshark-commits] master-1.10 bb3ce2e: MIP6: AUTH mobility option parses Mobility SPI and Authentication Data incorrectly,
Wireshark code review
- [Wireshark-commits] master ca534b1: MIP6: Local Mobility Anchor Address mobility option code is treated incorrectly,
Wireshark code review
- [Wireshark-commits] master-1.12 8300429: MIP6: Local Mobility Anchor Address mobility option code is treated incorrectly,
Wireshark code review
- [Wireshark-commits] master-1.10 b8bd5a2: MIP6: Local Mobility Anchor Address mobility option code is treated incorrectly,
Wireshark code review
- [Wireshark-commits] master 5cc0ad8: Remove a duplicate typedef.,
Wireshark code review
- [Wireshark-commits] master e11d7ef: Fix diagnostics macros and squelch a gcc warning.,
Wireshark code review
- [Wireshark-commits] master f80a720: WSUG and image updates.,
Wireshark code review
- [Wireshark-commits] master bade5f3: A small correction to the documentation to bring it in line with the code.,
Wireshark code review
- [Wireshark-commits] master 1b43a80: Note why some header checks are done even if unnecessary on UN*X.,
Wireshark code review
- [Wireshark-commits] master 65763cf: Try to fix diagnostic suppression.,
Wireshark code review
- [Wireshark-commits] master 29e1b45: IS-IS (LSP): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master bf15134: [Automatic manuf, services and enterprise-numbers update for 2015-02-15],
Wireshark code review
- [Wireshark-commits] master-1.12 0191876: [Automatic manuf, services and enterprise-numbers update for 2015-02-15],
Wireshark code review
- [Wireshark-commits] master-1.10 5d1c410: [Automatic manuf, services and enterprise-numbers update for 2015-02-15],
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] master e326318: Only call tvb_get_ptr() once to set src and dst addresses-,
Wireshark code review
- [Wireshark-commits] master 0ed1b0f19: Add ws_mempbrk_sse42_compile to Valgrind suppression list,
Wireshark code review
- [Wireshark-commits] master 7229c54: epan/ftypes/*.[hc]: As needed: Add editor modelines & Fix indentation,
Wireshark code review
- [Wireshark-commits] master bfde04b: ui/gtk/*.c: Add editor modelines; As needed: Fix indentation,
Wireshark code review
- [Wireshark-commits] master-1.12 75e735b: DHCPv6: add missing braces,
Wireshark code review
- [Wireshark-commits] master ad6d259: EtherCAT: Suppress pedantic warnings.,
Wireshark code review
- [Wireshark-commits] master 1917023: Don't base interpretation of LINKTYPE_ values on DLT_ value definitions.,
Wireshark code review
- [Wireshark-commits] master-1.12 a72c356: Don't base interpretation of LINKTYPE_ values on DLT_ value definitions.,
Wireshark code review
- [Wireshark-commits] master-1.10 56552b7: Don't base interpretation of LINKTYPE_ values on DLT_ value definitions.,
Wireshark code review
- [Wireshark-commits] master fea325d: Handle DLT_LOOP differently from DLT_NULL.,
Wireshark code review
- [Wireshark-commits] master f5902a6: Fix duplicate Display Filter Macro check,
Wireshark code review
- [Wireshark-commits] master 4f3646f: Fix handling of invalid UAT items,
Wireshark code review
- [Wireshark-commits] master-1.12 225d3bf: Fix duplicate Display Filter Macro check,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on OSX 10.7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on Windows 8.1 x86,
buildbot-no-reply
- [Wireshark-commits] master-1.10 2fcc8b8: Fix duplicate Display Filter Macro check,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on OSX 10.6 x86,
buildbot-no-reply
- [Wireshark-commits] master 2bec642: proto(.h): fix parameter 'offset' not found in the function declaration [-Wdocumentation],
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.6 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.5 x86,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 7 x64,
buildbot-no-reply
- [Wireshark-commits] master ea5f5be: Update Release Notes,
Wireshark code review
- [Wireshark-commits] master 45674b7: Qt: fix "Assigned value is garbage or undefined",
Wireshark code review
- [Wireshark-commits] master 876c322: Revert "Fix duplicate Display Filter Macro check",
Wireshark code review
- [Wireshark-commits] master 7c3fd2a: Revert "Revert "Fix duplicate Display Filter Macro check"",
Wireshark code review
- [Wireshark-commits] master-1.12 c067619: Revert "Fix duplicate Display Filter Macro check",
Wireshark code review
- [Wireshark-commits] master-1.10 609e616: Revert "Fix duplicate Display Filter Macro check",
Wireshark code review
- [Wireshark-commits] master e56f34e: Suppress more pedantic warnings.,
Wireshark code review
- [Wireshark-commits] master a4b3be5: Complete the RSVD Dissector further by handling SCSI requests.,
Wireshark code review
- [Wireshark-commits] master 0ce7fd4: Trivial Dead assignment fixes in configure,
Wireshark code review
- [Wireshark-commits] master b2d23ec: [STUN] Avoid fetching stuff twice from the tvb.,
Wireshark code review
- [Wireshark-commits] master b2c81bb: Make get_manuf_name return a const string.,
Wireshark code review
- [Wireshark-commits] master 7fee7df: [Diameter] Use proto_tree_add_bitmask() to add the diameter flags.,
Wireshark code review
- [Wireshark-commits] master 17828b5: [80211ac] Add partial beamforming support,
Wireshark code review
- [Wireshark-commits] master 5955efc: [80211ac] Change VHT MIMO Control to use add_bitmask,
Wireshark code review
- [Wireshark-commits] master 6331755: Get rid of duplicate typedef.,
Wireshark code review
- [Wireshark-commits] master febc2e1: Fix a portability problem raised by Guy Harris. My first implementation would not work on 32-bit platforms because I assumed that pointers were 64-bit items. I have now moved to a slightly different scheme suggested by Evan Huus.,
Wireshark code review
- [Wireshark-commits] master 4765bbc: RSVD: fix compilation with GLib < 2.22.0,
Wireshark code review
- [Wireshark-commits] master cfb1bc3: Put the 64-bit hash routines into a common file.,
Wireshark code review
- [Wireshark-commits] master 907f4e8: We now get that from common libwireshark code.,
Wireshark code review
- [Wireshark-commits] master db2395f: Fix declaration and export the routines.,
Wireshark code review
- [Wireshark-commits] master a5f4389: Whitespace fix (space before tab),
Wireshark code review
- [Wireshark-commits] master be5259d: OK, at least on my system uic is called uic-qt5, same for moc and rcc. Found while doing an accidental autofoo build instead of cmake build.,
Wireshark code review
- [Wireshark-commits] master 5ebc577: Fix FSF address.,
Wireshark code review
- [Wireshark-commits] master 1478db0: Fix up formatting and indentation a bit.,
Wireshark code review
- [Wireshark-commits] master bd91109: Added JSON native file support.,
Wireshark code review
- [Wireshark-commits] master 9150a92: Add missing json.h,
Wireshark code review
- [Wireshark-commits] master 0da88ba: Don't send an effectively empty message (no TVBs) to the SCTP tap.,
Wireshark code review
- [Wireshark-commits] master a355daf: Give users a more helpful error message if they enter an SSL protocol we don't know.,
Wireshark code review
- [Wireshark-commits] master-1.12 be37246: Don't send an effectively empty message (no TVBs) to the SCTP tap.,
Wireshark code review
- [Wireshark-commits] master c621a77: PCP: updated protocol dissection for new PDU types,
Wireshark code review
- [Wireshark-commits] master edf05db: Corrected display format for EUI-64,
Wireshark code review
- [Wireshark-commits] master fd870e3: CMIP: get rid of some evil global variables,
Wireshark code review
- [Wireshark-commits] master e61f3d5: 802.11: fix no previous prototype for 'wlan_col_filter_str' & 'wlan_bssid_col_filter_str' [-Wmissing-prototypes],
Wireshark code review
- [Wireshark-commits] master 2c43b68: Set a window icon for WiresharkDialog.,
Wireshark code review
- [Wireshark-commits] master da62086: WSUG: Add more dialog guidelines.,
Wireshark code review
- [Wireshark-commits] master-1.12 2cd23a4: CMIP: get rid of some evil global variables,
Wireshark code review
- [Wireshark-commits] master-1.10 55c1309: CMIP: get rid of some evil global variables,
Wireshark code review
- [Wireshark-commits] master 47f27e3: [Qt] don't clear the display filter when a capture file is closed,
Wireshark code review
- [Wireshark-commits] master eca4d29: STUN : fix indent (use 4spaces),
Wireshark code review
- [Wireshark-commits] master 23c8bb8: [zvt] dissect some more fields,
Wireshark code review
- [Wireshark-commits] master-1.12 309a847: Fix duplicate Display Filter Macro check,
Wireshark code review
- [Wireshark-commits] master-1.10 29de16d: Fix duplicate Display Filter Macro check,
Wireshark code review
- [Wireshark-commits] master efd18e6: A UAT's update is expected to set *error; do so.,
Wireshark code review
- [Wireshark-commits] master be5e595: Make it a bit more like the way it was before all these changes.,
Wireshark code review
- [Wireshark-commits] master-1.12 80653ca: A UAT's update is expected to set *error; do so.,
Wireshark code review
- [Wireshark-commits] master-1.10 0adb6ee: A UAT's update is expected to set *error; do so.,
Wireshark code review
- [Wireshark-commits] master-1.12 733f142: Make it a bit more like the way it was before all these changes.,
Wireshark code review
- [Wireshark-commits] master-1.10 6de1490: Make it a bit more like the way it was before all these changes.,
Wireshark code review
- [Wireshark-commits] master 3f765b3: Add a CF_FUNC macro for casting BASE_CUSTOM functions.,
Wireshark code review
- [Wireshark-commits] master-1.12 1ce91c0: Corrected display format for EUI-64,
Wireshark code review
- [Wireshark-commits] master-1.10 60c4d04: Corrected display format for EUI-64,
Wireshark code review
- [Wireshark-commits] master 859511d: Make UAT record update callbacks return a success/failure indication.,
Wireshark code review
- [Wireshark-commits] master 9d1ea65: Fix comments to reflect reality.,
Wireshark code review
- [Wireshark-commits] master b10bad1: Fix QCustmPlot retina problems.,
Wireshark code review
- [Wireshark-commits] master 909d891: Some additional UAT update callback changes.,
Wireshark code review
- [Wireshark-commits] master a5aab24: Add an appdata entry for Wireshark.,
Wireshark code review
- [Wireshark-commits] master b3f3d66: Update Qt version checks.,
Wireshark code review
- [Wireshark-commits] master 630f54f: Fix various warnings in wireshark-qt.cpp.,
Wireshark code review
- [Wireshark-commits] master 9707ff8: Uninstall wireshark.appdata.xml.,
Wireshark code review
- [Wireshark-commits] master 7263af8: Eliminate some DIRTY_ file lists.,
Wireshark code review
- [Wireshark-commits] master 4342333: libnl: disable pedantic warning of libnl lib,
Wireshark code review
- [Wireshark-commits] master b356887: Bugfix in ui/qt/CMakeLists.txt (missing file).,
Wireshark code review
- [Wireshark-commits] master 0dd7714: Add AddressSanitizer (ASAN) build option --enable-asan for autotools -D ENABLE_ASAN:BOOL=TRUE for CMake,
Wireshark code review
- [Wireshark-commits] master dd15191: Suppress a printf grouping warning.,
Wireshark code review
- [Wireshark-commits] master fb4252e: RADIUS: Add new dicto from FreeRADIUS,
Wireshark code review
- [Wireshark-commits] master 3a79d04: H.248: fix dissection of ServiceChangeReason for version 1,
Wireshark code review
- [Wireshark-commits] master fcc05a4: Use plain old ASCII for the SimpleDialog delimiter.,
Wireshark code review
- [Wireshark-commits] master e29dca7: Not all compilers support turning of "format=".,
Wireshark code review
- [Wireshark-commits] master-1.12 321d657: H.248: fix dissection of ServiceChangeReason for version 1,
Wireshark code review
- [Wireshark-commits] master-1.10 e015816: H.248: fix dissection of ServiceChangeReason for version 1,
Wireshark code review
- [Wireshark-commits] master 493ab6b: Check whether emmintrin.h can be used *without* -msse4.2.,
Wireshark code review
- [Wireshark-commits] master 58f7788: Move some ASN.1 dissectors to the clean list.,
Wireshark code review
- [Wireshark-commits] master 7d66c25: That's not an ASN.1 dissector (and gets warnings).,
Wireshark code review
- [Wireshark-commits] master ff1c33c: ssl: check for minimal SSLv3/TLS record size,
Wireshark code review
- [Wireshark-commits] master c8f6d21: Add a dissector for Microsoft's SSTP protocol.,
Wireshark code review
- [Wireshark-commits] master 6eae09f: lupdate for Italian (new strings translated),
Wireshark code review
- [Wireshark-commits] master 7208355: Don't put CORBA IDL dissectors in ASN1_ variables.,
Wireshark code review
- [Wireshark-commits] master 8d16ac4: Add name resolution support to address type.,
Wireshark code review
- [Wireshark-commits] master adf6f89: Add some casts to satisfy the various compilers.,
Wireshark code review
- [Wireshark-commits] master ca68a7a: Add some casts to satisfy the various compilers.,
Wireshark code review
- [Wireshark-commits] master d330cf7: Documentation fix (reported by Richard Sharpe).,
Wireshark code review
- [Wireshark-commits] master 9fba8c8: Bugfix in nbns dissector.,
Wireshark code review
- [Wireshark-commits] master b43fecb: patch for PMIPv6 MAG GPS coordinates,
Wireshark code review
- [Wireshark-commits] master 2bc71d3: openSAFETY: Merge both CT values,
Wireshark code review
- [Wireshark-commits] master 5c60289: Qt Wireshark - Once a live capture is stopped the title bar persists in reporting "Capturing from interface name",
Wireshark code review
- [Wireshark-commits] master 20e2c38: libnl: disable pedantic warning of libnl lib,
Wireshark code review
- [Wireshark-commits] master a6c44c2: [bmp] Adding dissector for BGP Monitoring Protocol,
Wireshark code review
- [Wireshark-commits] master-1.12 b1759d3: Bugfix in nbns dissector.,
Wireshark code review
- [Wireshark-commits] master c200f1e: Rename packet-nbns.c to packet-nbt.c to reflect that it's not just NBNS.,
Wireshark code review
- [Wireshark-commits] master 999bbc9: Qt: Add more version and packaging information to the main window.,
Wireshark code review
- [Wireshark-commits] master 0d3b51a: Remove quotes from an Nmake macro.,
Wireshark code review
- [Wireshark-commits] master ec6ec49: Qt: Fix automatic update status in welcome screen.,
Wireshark code review
- [Wireshark-commits] master 9423a13: Just have init_progfile_dir() take a void pointer.,
Wireshark code review
- [Wireshark-commits] master 95382c3: Suppress a bunch of cast-qual warnings.,
Wireshark code review
- [Wireshark-commits] master f89edfd: addr_resolv: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 56356b8: MCPE: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master c84b022: MQTT: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master a99cc2f: address_types.c: fix a "conditional jump or move depends on uninitialised value" error found by Valgrind,
Wireshark code review
- [Wireshark-commits] master 9fe9505: addr_resolv.c: fix a stack buffer overflow detected by ASAN,
Wireshark code review
- [Wireshark-commits] master bccb7f7: [Diameter] It's MCC first in 3GPP AVP 909 RAI,
Wireshark code review
- [Wireshark-commits] master 1a10f5f: ui/gtk: fix control combos such as ctrl-a, ctrl-c,
Wireshark code review
- [Wireshark-commits] buildbot failure in Wireshark 1.12 on Fuzz Test,
buildbot-no-reply
- [Wireshark-commits] master 422ad10: Qt: Apply the main window geometry directly.,
Wireshark code review
- [Wireshark-commits] master-1.12 4e95af7: Fix CMake builds,
Wireshark code review
- [Wireshark-commits] master ead79e6: Clear the filter expression list in prefs.c.,
Wireshark code review
- [Wireshark-commits] master ae9cc88: Qt: Fix unsaved changes behavior.,
Wireshark code review
- [Wireshark-commits] master 5012cf8: Call pre_init_prefs each time our profile changes.,
Wireshark code review
- [Wireshark-commits] master c1b672c: checkAPIs: match packet-*.[ch], independent of locale,
Wireshark code review
- [Wireshark-commits] master 13531d3: Convert dissectors to use address_with_resolution_to_str instead of two separate calls for address string and name resolution.,
Wireshark code review
- [Wireshark-commits] master e2bcee6: Make FT_{U}INT64 behave more like FT_{U}INT32, add support for FT_{U}INT{40, 48, 56},
Wireshark code review
- [Wireshark-commits] master c093797: Fix GTK-shark,
Wireshark code review
- [Wireshark-commits] master 2d1d83a: Use correct mem scope for source address in Text Logcat,
Wireshark code review
- [Wireshark-commits] master 8e43698: Set phdr encap for pcap file,
Wireshark code review
- [Wireshark-commits] master 9ad00fd: Qt: Fix for QT < 4.8,
Wireshark code review
- [Wireshark-commits] master b8388c6: Ftypes: Double: Minor fixes,
Wireshark code review
- [Wireshark-commits] master ffeadb7: Bluetooth/GUI: ATT: Use alphabetical order in makefile,
Wireshark code review
- [Wireshark-commits] master 1694e81: The shortening to 32 bits is intentional, so add a cast.,
Wireshark code review
- [Wireshark-commits] master 0808fc0: 64-bit constants need to be wrapped in G_G{U}INT64_CONSTANT().,
Wireshark code review
- [Wireshark-commits] master f868da2: Update Debian symbols file.,
Wireshark code review
- [Wireshark-commits] master f12d231: More wrapping of constants with G_GUINT64_CONSTANT().,
Wireshark code review
- [Wireshark-commits] master e35aa1f: Move declarations of internal ws_mempbrk routines to a separate header.,
Wireshark code review
- [Wireshark-commits] master f3a68f0: Rename the slower-but-portable mempbrk to ws_mempbrk_portable_exec().,
Wireshark code review
- [Wireshark-commits] master bfb4327: Remove tvb_ from the names of wsutil mempbrk routines.,
Wireshark code review
- [Wireshark-commits] master ddafa7e: Update Debian symbols list.,
Wireshark code review
- [Wireshark-commits] master-1.12 b9c0644: Fix typo.,
Wireshark code review
- [Wireshark-commits] master-1.12 aee8075: http: properly calculate end of chunked response,
Wireshark code review
- [Wireshark-commits] master-1.12 afc48b4: FT_{U}INT64 doesn't work with BASE_CUSTOM.,
Wireshark code review
- [Wireshark-commits] master 8d5da72: Add tvb_address_with_resolution_to_str.,
Wireshark code review
- [Wireshark-commits] master 2196378: Fetch values appropriately according to the value's type.,
Wireshark code review
- [Wireshark-commits] master 1157aa8: Set 64-bit signed values with proto_tree_set_int64().,
Wireshark code review
- [Wireshark-commits] master d1865e0: Make FT_{U}INT{40, 48, 56, 64} handle BASE_CUSTOM.,
Wireshark code review
- [Wireshark-commits] master 73508e8: [Automatic manuf, services and enterprise-numbers update for 2015-02-22],
Wireshark code review
- [Wireshark-commits] master-1.12 d8fd860: [Automatic manuf, services and enterprise-numbers update for 2015-02-22],
Wireshark code review
- [Wireshark-commits] master-1.10 a404c6a: [Automatic manuf, services and enterprise-numbers update for 2015-02-22],
Wireshark code review
- [Wireshark-commits] master 99ff8ba: Use file extensions even more as a heuristic.,
Wireshark code review
- [Wireshark-commits] master-1.12 6457715: Use file extensions even more as a heuristic.,
Wireshark code review
- [Wireshark-commits] master-1.12 20fa170: Fix build error.,
Wireshark code review
- [Wireshark-commits] master 066ae91: Put back address family field.,
Wireshark code review
- [Wireshark-commits] master-1.12 a3fe006: Put back address family field.,
Wireshark code review
- [Wireshark-commits] master 08bee7d: Clean up display of raw hex latitude/longitude values.,
Wireshark code review
- [Wireshark-commits] master b9296b7: Fix handling of longitude and latitude values.,
Wireshark code review
- [Wireshark-commits] master-1.12 1960295: Put back the padding, but do zero-padding.,
Wireshark code review
- [Wireshark-commits] master 1c4053f: BMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 6765bf7: Fix generation of address-with-resolution strings.,
Wireshark code review
- [Wireshark-commits] master-1.12 a86a915: ui/gtk: fix control combos such as ctrl-a, ctrl-c,
Wireshark code review
- [Wireshark-commits] master 4c994e3: L2CAP information message contained two bits that were wrongly dissected.,
Wireshark code review
- [Wireshark-commits] master 306c819: jmirror packet dissector expects ipv6 flow label = 0,
Wireshark code review
- [Wireshark-commits] master d488d63: ssl-utils: refactor keyfile matching,
Wireshark code review
- [Wireshark-commits] master 9667666: ui/gtk: use GTK+ 2 name for control keys,
Wireshark code review
- [Wireshark-commits] master-1.12 bb85d50: ui/gtk: use GTK+ 2 name for control keys,
Wireshark code review
- [Wireshark-commits] master 255de16: RSVD: add missing initialization of lun parameter,
Wireshark code review
- [Wireshark-commits] master 2899cf4: Don't add redundant information to the top-level flags item for NBNS.,
Wireshark code review
- [Wireshark-commits] master 4a07667: Get rid of no-longer-needed variables.,
Wireshark code review
- [Wireshark-commits] master 5e34492: BSSMAP: VGCS/VBS Assignment Request wrong first parameter,
Wireshark code review
- [Wireshark-commits] master a6f4bdb: pcap-common: fix build error with gcc5,
Wireshark code review
- [Wireshark-commits] master 770ac91: Qt: Fix a crash when changing the layout.,
Wireshark code review
- [Wireshark-commits] master b9af5a5: proto.c: avoid corrupting stack when printing a 64 bits field in BASE_DEC_HEX or BASE_HEX_DEC format,
Wireshark code review
- [Wireshark-commits] master 30651ab: DNS: Ignore Client Subnet option's data length when > 16,
Wireshark code review
- [Wireshark-commits] master c466d40: NS Trace (NetScaler Trace) file format is not able to export specified packets,
Wireshark code review
- [Wireshark-commits] master 4ee6bcb: websocket: avoid recursion, use tcp_dissect_pdus,
Wireshark code review
- [Wireshark-commits] master b125fea: epan: fix build error with gcc5,
Wireshark code review
- [Wireshark-commits] master-1.12 f49ab95: epan: fix build error with gcc5,
Wireshark code review
- [Wireshark-commits] master-1.10 590bda3: epan: fix build error with gcc5,
Wireshark code review
- [Wireshark-commits] master-1.12 0c7032c: pcap-common: fix build error with gcc5,
Wireshark code review
- [Wireshark-commits] master f9fc252: exntest: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang,
Wireshark code review
- [Wireshark-commits] master 30ed6a1: Qt: Apply recent settings.,
Wireshark code review
- [Wireshark-commits] master c0c6278: openSAFETY: Remove Macro and clear dissection,
Wireshark code review
- [Wireshark-commits] master c280a40: Qt: Escape ampersands in checkboxes and radio buttons.,
Wireshark code review
- [Wireshark-commits] master ced6fba: Revert "exntest: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang",
Wireshark code review
- [Wireshark-commits] master-1.12 49ec8ed: NS Trace (NetScaler Trace) file format is not able to export specified packets,
Wireshark code review
- [Wireshark-commits] master fe5aea7: Move the setting of rec_type.,
Wireshark code review
- [Wireshark-commits] master-1.12 7ee27cf: Move the setting of rec_type.,
Wireshark code review
- [Wireshark-commits] master 2a31311: Have PACKET_DESCRIBE() for V10.,
Wireshark code review
- [Wireshark-commits] master-1.12 efb0761: Have PACKET_DESCRIBE() for V10.,
Wireshark code review
- [Wireshark-commits] master 592ee9e: Swallow up more V10 stuff into PACKET_DESCRIBE().,
Wireshark code review
- [Wireshark-commits] master-1.12 6b32774: Swallow up more V10 stuff into PACKET_DESCRIBE().,
Wireshark code review
- [Wireshark-commits] master 37c09e3: Pull more into PACKET_DESCRIBE() for the V10 seek-read routine.,
Wireshark code review
- [Wireshark-commits] master-1.12 933ca8d: Pull more into PACKET_DESCRIBE() for the V10 seek-read routine.,
Wireshark code review
- [Wireshark-commits] master 0dc5edf: Clean up indentation.,
Wireshark code review
- [Wireshark-commits] master-1.12 2d7055f: Clean up indentation.,
Wireshark code review
- [Wireshark-commits] master c4b76a9: More indentation cleanups.,
Wireshark code review
- [Wireshark-commits] master-1.12 1f6916e: More indentation cleanups.,
Wireshark code review
- [Wireshark-commits] master 08c85ec: Call header version arguments HEADERVER.,
Wireshark code review
- [Wireshark-commits] master-1.12 4db9cce: Call header version arguments HEADERVER.,
Wireshark code review
- [Wireshark-commits] master-1.12 ddc789d: White space cleanups.,
Wireshark code review
- [Wireshark-commits] master 04b6b56: Give all PACKET_DESCRIBE() macros a HEADERVER argument.,
Wireshark code review
- [Wireshark-commits] master-1.12 6346e81: Give all PACKET_DESCRIBE() macros a HEADERVER argument.,
Wireshark code review
- [Wireshark-commits] master 22b4b63: Get rid of an unused argument to PACKET_DESCRIBE().,
Wireshark code review
- [Wireshark-commits] master-1.12 82e639a: Get rid of an unused argument to PACKET_DESCRIBE().,
Wireshark code review
- [Wireshark-commits] master fc6df64: Use FULL/PART as an argument to all PACKET_DESCRIBE() macros.,
Wireshark code review
- [Wireshark-commits] master-1.12 abe5692: Use FULL/PART as an argument to all PACKET_DESCRIBE() macros.,
Wireshark code review
- [Wireshark-commits] master 825a833: Call the version-number argument to GENERATE_CASE_xxx() "ver".,
Wireshark code review
- [Wireshark-commits] master-1.12 e238b98: Call the version-number argument to GENERATE_CASE_xxx() "ver".,
Wireshark code review
- [Wireshark-commits] master 0856de5: Rename the "type" argument to V10's PACKET_DESCRIBE() to "ver".,
Wireshark code review
- [Wireshark-commits] master-1.12 e780e98: Rename the "type" argument to V10's PACKET_DESCRIBE() to "ver".,
Wireshark code review
- [Wireshark-commits] master 98e8d52: Make the V10 PACKET_DESCRIBE() macro a little more like the others.,
Wireshark code review
- [Wireshark-commits] master-1.12 caec90e: Make the V10 PACKET_DESCRIBE() macro a little more like the others.,
Wireshark code review
- [Wireshark-commits] master 6b6c11c: Have a PACKET_DESCRIBE() for V30's seek-read routine.,
Wireshark code review
- [Wireshark-commits] master-1.12 8499a9f: Have a PACKET_DESCRIBE() for V30's seek-read routine.,
Wireshark code review
- [Wireshark-commits] master 9dfade3: Make the _offset values static constants.,
Wireshark code review
- [Wireshark-commits] master-1.12 10c1634: Make the _offset values static constants.,
Wireshark code review
- [Wireshark-commits] master-1.12 2d151f1: L2CAP information message contained two bits that were wrongly dissected.,
Wireshark code review
- [Wireshark-commits] master-1.10 bd41179: L2CAP information message contained two bits that were wrongly dissected.,
Wireshark code review
- [Wireshark-commits] master-1.12 c2a1fc8: jmirror packet dissector expects ipv6 flow label = 0,
Wireshark code review
- [Wireshark-commits] master-1.10 f1ceee9: jmirror packet dissector expects ipv6 flow label = 0,
Wireshark code review
- [Wireshark-commits] master-1.12 ee771c7: BSSMAP: VGCS/VBS Assignment Request wrong first parameter,
Wireshark code review
- [Wireshark-commits] master-1.10 d24a64a: BSSMAP: VGCS/VBS Assignment Request wrong first parameter,
Wireshark code review
- [Wireshark-commits] master 03988e9: Add the ATN dissectors to the CMake build.,
Wireshark code review
- [Wireshark-commits] master be68cdb: [Diameter] Add some AVPs and AVP values from 3GPP TS 32.299 version 12.7.0 (2015-01) Ping-Bug:11008 Change-Id: Ib7f52c743f43d8a1c70c9fb100663292d7c4a87e Reviewed-on: https://code.wireshark.org/review/7387 Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>,
Wireshark code review
- [Wireshark-commits] master 618eaec: delete_includes.py: add target for ui/qt,
Wireshark code review
- [Wireshark-commits] master 1a3dd34: ATN-CPDLC: never put a break in a TRY block,
Wireshark code review
- [Wireshark-commits] master-1.12 572ce10: ATN-CPDLC: never put a break in a TRY block,
Wireshark code review
- [Wireshark-commits] master 0692d75: Make the V10 path a bit more like the other paths.,
Wireshark code review
- [Wireshark-commits] master-1.12 acbd5ac: Make the V10 path a bit more like the other paths.,
Wireshark code review
- [Wireshark-commits] master 4e12b59: Check whether we HAVE_GETADDRINFO before using it.,
Wireshark code review
- [Wireshark-commits] master 3336f71: Actually define HAVE_GETADDRINFO if we find it.,
Wireshark code review
- [Wireshark-commits] master b034870: Fix a couple of bugs in IPMI dissector:,
Wireshark code review
- [Wireshark-commits] master-1.12 be9397b: Fix a couple of bugs in IPMI dissector:,
Wireshark code review
- [Wireshark-commits] master 96d1ce0: chdlc: Added "control" to proto tree.,
Wireshark code review
- [Wireshark-commits] master-1.12 d7c62c8: Restore synchronous name resolution (revert SVN rev52115).,
Wireshark code review
- [Wireshark-commits] master 29feae5: Use tcp_dissect_pdus() in the SSTP dissector.,
Wireshark code review
- [Wireshark-commits] master bcf870e: SMPP: AT_STRINGZ address allocation must use the pinfo pool,
Wireshark code review
- [Wireshark-commits] master 3546914: rsync: improved info for protocol.,
Wireshark code review
- [Wireshark-commits] master-1.12 e23e1dc: SMPP: AT_STRINGZ address allocation must use the pinfo pool,
Wireshark code review
- [Wireshark-commits] master d60d473: Qt: Update translation,
Wireshark code review
- [Wireshark-commits] master 50b15cc: Translations : fix trailing whitespace when generate translations file,
Wireshark code review
- [Wireshark-commits] master e914bd5: [GTP CDR] Add support for CDR data record format version 12.6.0,
Wireshark code review
- [Wireshark-commits] master-1.12 98993f4: Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up with gcc 4.8.3.,
Wireshark code review
- [Wireshark-commits] master-1.12 c892845: Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up on the OSX 10.5 buildbot.,
Wireshark code review
- [Wireshark-commits] master 123be13: ANSI IS-637 A: ensure that num_fields is not null before calling text_decoder,
Wireshark code review
- [Wireshark-commits] master-1.12 2a4773e: ANSI IS-637 A: ensure that num_fields is not null before calling text_decoder,
Wireshark code review
- [Wireshark-commits] master 3e5c0bf: Qt: Fix packet detail and byte view scrolling,
Wireshark code review
- [Wireshark-commits] master 8ae714d: Remove a dead assignment found by Clang.,
Wireshark code review
- [Wireshark-commits] master 0f29e5d: isis: bugfix in csnp source id length.,
Wireshark code review
- [Wireshark-commits] master 1e66e74: Add dissector for "Bad Password Threshold" IPMI LAN configuration parameter.,
Wireshark code review
- [Wireshark-commits] master 9ac60ff: address_to_string routines need to remember the beginning of the buffer.,
Wireshark code review
- [Wireshark-commits] master 64c0678: Again, we need a separate pointer to advance through the buffer.,
Wireshark code review
- [Wireshark-commits] master 14697b8: Pass tvb and offset into print_nsap_net() and print_area() to "hide" the tvb_get_ptr call that dissectors are using.,
Wireshark code review
- [Wireshark-commits] master 0002424: Remove most of the tvb_get_ptr calls in the packet-batadv.c dissector.,
Wireshark code review
- [Wireshark-commits] master 9cc49a7: Updated MAUSB Packet Type values,
Wireshark code review
- [Wireshark-commits] master bc8228b: Added Dissection of CancelTransfer MA packets,
Wireshark code review
- [Wireshark-commits] master 2366113: Added basic MA USB isochronous packet support,
Wireshark code review
- [Wireshark-commits] master e4afcc8: Fixed MAUSB Flags subfield dissection,
Wireshark code review
- [Wireshark-commits] master 2462c0d: Use VCINSTALLDIR environment variable in order to locate MSVCR_DLL. This fixes Windows build in cases when MSVS is installed in non-default directory.,
Wireshark code review
- [Wireshark-commits] master 2d48179: Qt: Automatically scroll the packet list.,
Wireshark code review
- [Wireshark-commits] master e5e8af9: Restore synchronous name resolution (revert SVN rev52115).,
Wireshark code review
- [Wireshark-commits] master edb5e4b: Use getnameinfo() instead of gethostbyaddr().,
Wireshark code review
- [Wireshark-commits] master 5e2dcb3: Remove a couple useless variables.,
Wireshark code review
- [Wireshark-commits] master 823766b: We don't use gethostbyname2(), don't check for it.,
Wireshark code review
- [Wireshark-commits] master 81fa9e0: wmem, unlike emem, doesn't use mmap(); remove some no-longer-needed checks.,
Wireshark code review
- [Wireshark-commits] master 8c86fbc: <string.h>, not <memory.h>, is the header file for memcpy().,
Wireshark code review
- [Wireshark-commits] master dbbb1d3: We don't need to check for strings.h.,
Wireshark code review
- [Wireshark-commits] master-1.12 ba919f9: Prep for 1.12.4.,
Wireshark code review
- [Wireshark-commits] master-1.12 99a12b9: Fix handling of invalid UAT items,
Wireshark code review
- [Wireshark-commits] master-1.10 5db43d1: Fix handling of invalid UAT items,
Wireshark code review
- [Wireshark-commits] master 60cc2e0: Clean up timestamp handling.,
Wireshark code review
- [Wireshark-commits] master abd8be3: Get rid of unused variable.,
Wireshark code review
- [Wireshark-commits] master 30d878f: openSAFETY: Add support for openSAFETY 1.5,
Wireshark code review
- [Wireshark-commits] master 3b23561: Don't use struct timeval if we only care about seconds.,
Wireshark code review
- [Wireshark-commits] master 65303ef: Remove some unneeded includes of <sys/time.h>.,
Wireshark code review
- [Wireshark-commits] master 5892d3c: Don't use ctime().,
Wireshark code review
- [Wireshark-commits] master 7130875: Convert fixed-point binary to floating-point in a portable fashion.,
Wireshark code review
Mail converted by MHonArc
