Wireshark-commits: [Wireshark-commits] master-1.12 321d657: H.248: fix dissection of ServiceChangeR
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Feb 2015 20:22:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=321d65719413bbdd305fa3f90138d30b7260a71c
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

321d657 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    H.248: fix dissection of ServiceChangeReason for version 1
    
    My understanding of RFC 3015 is that the encoding of this field was not different in version 1 compared to newer releases
    
    Bug: 10879
    Change-Id: Iaa81679388860c0df4adc673ca6e56aff6f4591c
    Reviewed-on: https://code.wireshark.org/review/7195
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 3a79d04626f2ee1e03040c545fc996a4aec96a76)
    Conflicts:
    	asn1/h248/h248.cnf
    	epan/dissectors/packet-h248.c
    Reviewed-on: https://code.wireshark.org/review/7242
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  1ce91c0   Corrected display format for EUI-64
    adds  321d657   H.248: fix dissection of ServiceChangeReason for version 1


Summary of changes:
 asn1/h248/h248.cnf               |   43 -----------------------------
 asn1/h248/h248v1support.asn      |    2 +-
 asn1/h248/packet-h248-template.c |    2 +-
 epan/dissectors/packet-h248.c    |   55 +++-----------------------------------
 4 files changed, 6 insertions(+), 96 deletions(-)