Wireshark-commits: [Wireshark-commits] master-1.12 b63b257: DNS NXT RR is parsed incorrectly
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 7 Feb 2015 18:27:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b63b257ed844b2148813603a2b9ada6c932b45fd
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

b63b257 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    DNS NXT RR is parsed incorrectly
    
    The queries RRs and answers RRs are parsed fine.
    However, only the first 2 authoritative RRs are parsed and none of the 3 additional RRs are parsed.
    The second authoritative RR is of type NXT, and even though it has data length of 9, Wireshark reads all the bytes until the end of the packet as if they are part of bitmap in this RR (it reads 317 bytes too many).
    This causes it to not parse the rest of the RRs correctly.
    
    Found by boaz
    
    Bug:10615
    Change-Id: I22e5987c44a11399b07c3106fbb70c6e9e867afe
    Reviewed-on: https://code.wireshark.org/review/4940
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 09957ca41875abda6e9ea24f35eb15f93dacb618)
    Reviewed-on: https://code.wireshark.org/review/7007
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  baff3a3   cfdp: Fix bug ("Labeled code is unreachable")
    adds  b63b257   DNS NXT RR is parsed incorrectly


Summary of changes:
 epan/dissectors/packet-dns.c |   29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)