Wireshark-commits: [Wireshark-commits] master-1.10 d24a64a: BSSMAP: VGCS/VBS Assignment Request wro
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 25 Feb 2015 11:31:08 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d24a64a9b74f724b6efec7ddf02eb61fcc7faaeb
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

d24a64a by unknown (drkor@xxxxxxxxx):

    BSSMAP: VGCS/VBS Assignment Request wrong first parameter
    
    According to specification first mandatary parameter is Channel Type (BE_CHAN_TYPE)
    but not Current Channel Type 1 (BE_CURR_CHAN_1).
    And also "Channel Type" is TLV but not TV type.
    
    Change-Id: I740dc10930a854fcb1cf2e09a19d57a16f8cf33e
    Reviewed-on: https://code.wireshark.org/review/7330
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 5e34492a7e0196baa9e14d004477d1c233d38650)
    Conflicts:
    	epan/dissectors/packet-gsm_a_bssmap.c
    Reviewed-on: https://code.wireshark.org/review/7385
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  f1ceee9   jmirror packet dissector expects ipv6 flow label = 0
    adds  d24a64a   BSSMAP: VGCS/VBS Assignment Request wrong first parameter


Summary of changes:
 epan/dissectors/packet-gsm_a_bssmap.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)