Wireshark-commits: [Wireshark-commits] master 00f7bc4: Qt: Fix IO Graph capture file closing.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 3 Feb 2015 01:20:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=00f7bc4b3d13639576d4faf964995daf7f449d69
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

00f7bc4 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fix IO Graph capture file closing.
    
    Make sure our IOGraphs remove their respective tap listeners before the
    capture file closes, otherwise the graph data ends up getting cleared
    via reset_tap_listeners.
    
    Bug: 10871
    Change-Id: I0ef2af2dc84be1921a930df8bb68f63626aa874a
    Reviewed-on: https://code.wireshark.org/review/6925
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  9d7f5c7   ISIS: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
    adds  00f7bc4   Qt: Fix IO Graph capture file closing.


Summary of changes:
 ui/qt/io_graph_dialog.cpp |   12 +++++++-----
 ui/qt/io_graph_dialog.h   |    1 +
 2 files changed, 8 insertions(+), 5 deletions(-)