Wireshark-commits: [Wireshark-commits] master 630f54f: Fix various warnings in wireshark-qt.cpp.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Feb 2015 05:01:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=630f54fbbc05d04ebc7007a2d6762514f5c066aa
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

630f54f by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Fix various warnings in wireshark-qt.cpp.
    
    Squelch warnings due to (char *) casts.
    
    Use "include_directories(SYSTEM..." in CMakeLists.txt so that we
    don't get pedantic warnings about things we can't easily fix such
    as QList loop optimizations. Not sure if there's an easy way to do
    this in Autotools.
    
    Pass get_gui_compiled_info to init_progfile_dir. C++ don't have to
    show you any stinkin' ::main.
    
        warning: ISO C++ forbids taking address of function ‘::main’ [-Wpedantic]
    
    Change-Id: If1c77284ab0d1b4786bce4e926a4109dd9b1ae34
    Reviewed-on: https://code.wireshark.org/review/7207
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  b3f3d66   Update Qt version checks.
    adds  630f54f   Fix various warnings in wireshark-qt.cpp.


Summary of changes:
 CMakeLists.txt      |    2 +-
 wireshark-qt.cpp    |    6 +++++-
 wsutil/filesystem.c |    2 +-
 wsutil/filesystem.h |    3 ++-
 4 files changed, 9 insertions(+), 4 deletions(-)