Wireshark-commits: [Wireshark-commits] master ae9cc88: Qt: Fix unsaved changes behavior.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 21 Feb 2015 02:06:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ae9cc88c007a61bde620f9efd5c422751388fff3
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ae9cc88 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fix unsaved changes behavior.
    
    Check the return value of testCaptureFileClose in
    MainWindow::openCaptureFile and add testCaptureFileClose to
    MainWindow::closeEvent. Some of the file opening and closing behavior
    still needs to be cleaned up but this should at least keep the user from
    losing unsaved data.
    
    Bug: 10944
    Change-Id: I7d7b563a6b72f48b41a5a3aff2837655557869ff
    Reviewed-on: https://code.wireshark.org/review/7283
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  ead79e6   Clear the filter expression list in prefs.c.
    adds  ae9cc88   Qt: Fix unsaved changes behavior.


Summary of changes:
 ui/qt/capture_file.cpp      |   14 +++++---------
 ui/qt/main_window.cpp       |    5 +++++
 ui/qt/main_window_slots.cpp |    2 +-
 3 files changed, 11 insertions(+), 10 deletions(-)