Wireshark-commits: [Wireshark-commits] master 29feae5: Use tcp_dissect_pdus() in the SSTP dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 Feb 2015 12:34:55 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29feae5f98ad2853b571a3daa5262b14c5d0c144
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

29feae5 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Use tcp_dissect_pdus() in the SSTP dissector.
    
    I happened across the discussion in Ia44e0791b6ee78ad594de342c4f2401bad9beb4e
    which indicates that protocols running over SSL can use tcp_dissect_pdus() too.
    So do it in the SSTP dissector.
    
    Change-Id: I3de14c1b2af5e4e5fe3630121366b71a5ad223cf
    Reviewed-on: https://code.wireshark.org/review/7333
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  96d1ce0   chdlc: Added "control" to proto tree.
    adds  29feae5   Use tcp_dissect_pdus() in the SSTP dissector.


Summary of changes:
 epan/dissectors/packet-http.c |    7 +++++++
 epan/dissectors/packet-sstp.c |   35 +++++++++++++++++------------------
 2 files changed, 24 insertions(+), 18 deletions(-)