Wireshark-commits: [Wireshark-commits] master 4497bb4: Add address type registration.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 9 Feb 2015 01:12:04 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4497bb48fd3439474049f7c5e86b4ffa1df35828
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4497bb4 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Add address type registration.
    
    Now address types are setup just like field types and must be registered with a structure that provides its string representation (and more things in the future).  Address types that are limited to a single dissector are registered by the dissector.  More "common" ones are globally registered.  There are still a few that really belong in a dissector, but have other dependencies currently not accounted for in the address type support.
    
    Many of the "address to string" conversions that involved g_sprintf have be changed to use more "performance friendly" methods (some at the cost of needing to_str-int.h)
    
    Leaving all comments regarding this "solution" in address_to_str.c in until all have been implemented
    
    Change-Id: I494f413e016b22859c44675def11135f228796e0
    Reviewed-on: https://code.wireshark.org/review/7019
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  3b81c36   DNS: LOC Precision missing units
    adds  4497bb4   Add address type registration.


Summary of changes:
 asn1/atn-ulcs/packet-atn-ulcs-template.c      |    7 +-
 epan/CMakeLists.txt                           |    2 +-
 epan/Makefile.common                          |    4 +-
 epan/address.h                                |   13 +-
 epan/address_to_str.c                         |  264 +---------
 epan/address_types.c                          |  702 +++++++++++++++++++++++++
 ui/persfilepath_opt.h => epan/address_types.h |   35 +-
 epan/column-utils.c                           |    1 -
 epan/dissectors/packet-atn-ulcs.c             |   17 +-
 epan/dissectors/packet-clnp.c                 |   10 +-
 epan/dissectors/packet-devicenet.c            |   30 +-
 epan/dissectors/packet-ieee802154.c           |   38 +-
 epan/dissectors/packet-j1939.c                |   25 +-
 epan/dissectors/packet-sna.c                  |   87 ++-
 epan/dissectors/packet-tipc.c                 |   66 ++-
 epan/osi-utils.c                              |   38 +-
 epan/osi-utils.h                              |    3 +
 epan/packet.c                                 |    1 -
 epan/proto.c                                  |    4 +
 epan/sna-utils.c                              |   80 ---
 epan/sna-utils.h                              |   39 --
 epan/to_str.c                                 |    2 +-
 22 files changed, 1011 insertions(+), 457 deletions(-)
 create mode 100644 epan/address_types.c
 copy ui/persfilepath_opt.h => epan/address_types.h (56%)
 delete mode 100644 epan/sna-utils.c
 delete mode 100644 epan/sna-utils.h