Wireshark-commits: [Wireshark-commits] master bdcac17: Fix crash at startup in SSE4.2 code when run
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Feb 2015 16:37:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bdcac172eaa2ec4998c9f2775e691460b9b7a2d0
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bdcac17 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Fix crash at startup in SSE4.2 code when running a 32 bits Windows build
    
    There is no guarantee that a g_malloc'ed memory block will be aligned on a 128 bits boundary
    Instead use a static variable definition (at the cost of exposing the HAVE_SSE4_2 compilation flag in ws_mempbrk.h)
    
    Change-Id: I661bf479a9d458d64c96bafc940c519d29a4780b
    Reviewed-on: https://code.wireshark.org/review/7070
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  678a9b6   BT ATT: memory given to add_new_data_source() must be allocated in pinfo scope
    adds  bdcac17   Fix crash at startup in SSE4.2 code when running a 32 bits Windows build


Summary of changes:
 epan/dissectors/packet-cups.c   |    2 +-
 epan/dissectors/packet-irc.c    |    2 +-
 epan/dissectors/packet-megaco.c |    4 ++--
 epan/dissectors/packet-sdp.c    |    4 ++--
 epan/dissectors/packet-sip.c    |   18 +++++++++---------
 epan/tvbuff.c                   |    4 ++--
 wsutil/ws_mempbrk.h             |   16 +++++++++-------
 wsutil/ws_mempbrk_sse42.c       |   18 +++++++-----------
 8 files changed, 33 insertions(+), 35 deletions(-)