Wireshark-commits: [Wireshark-commits] master ef929ad: TOS-specific forwarding blocks aren't actual
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 4 Feb 2015 07:07:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ef929aded5676a5091bfda4d205f1ef2a1018eaa
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ef929ad by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    TOS-specific forwarding blocks aren't actually required: don't warn when they
    aren't present.  Only warn if no forwarding blocks are present.
    
    Simplify the code a bit while also removing a proto_tree_add_text().  (There
    are a number of similar proto_tree_add_texts()s here.)
    
    Hang the "no forwarding blocks" expert info off the LSA item rather than off
    the Metric.  The warning is about how much data is in the LSA--it has
    nothing to do with the Metric.
    
    Ping-Bug: 6302
    Change-Id: I1903ba5ad78101ec4fa2602a1f21e8192f1d8d53
    Reviewed-on: https://code.wireshark.org/review/6943
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  8efe6b7   RADIUS: Sync with FreeRADIUS Master
    adds  ef929ad   TOS-specific forwarding blocks aren't actually required: don't warn when they aren't present.  Only warn if no forwarding blocks are present.


Summary of changes:
 epan/dissectors/packet-ospf.c |   49 +++++++++++++++++++----------------------
 1 file changed, 23 insertions(+), 26 deletions(-)