Wireshark-commits: [Wireshark-commits] master c0c6278: openSAFETY: Remove Macro and clear dissectio
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Feb 2015 12:29:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c0c62783860965f44f19cca5c5b43459042018f9
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c0c6278 by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):

    openSAFETY: Remove Macro and clear dissection
    
     Removing the macros for packet sender/receiver as it makes
     the code hard to read and maintain. the more generic routine
     opensafety_packet_node is also used for displaying the time
     request sender and recipient.
    
     Also clearing up the message id field, as it is the wrong size
     and making the detection for the value an hf_field with an
     array value.
    
    Change-Id: I31cf0f944fe803fb503f4c5d29e106dfae0f6938
    Reviewed-on: https://code.wireshark.org/review/7344
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  30ed6a1   Qt: Apply recent settings.
    adds  c0c6278   openSAFETY: Remove Macro and clear dissection


Summary of changes:
 epan/dissectors/packet-opensafety.c |  178 +++++++++++++++++------------------
 1 file changed, 84 insertions(+), 94 deletions(-)