Wireshark-commits: [Wireshark-commits] master ead79e6: Clear the filter expression list in prefs.c.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Feb 2015 23:16:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ead79e6aa15210cf83032698d7d17eb54a3d0857
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ead79e6 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Clear the filter expression list in prefs.c.
    
    Move filter_expression_nuke from ui/gtk to epan and rename it to
    filter_expression_free. Call it in prefs_reset along with the other
    preference reset routines.
    
    This keeps the Qt filter toolbar from filling up with duplicate
    expressions when the profile changes.
    
    Change-Id: I9fae9a7b48944079ea342a126979d9e79af0d22b
    Reviewed-on: https://code.wireshark.org/review/7281
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  422ad10   Qt: Apply the main window geometry directly.
    adds  ead79e6   Clear the filter expression list in prefs.c.


Summary of changes:
 debian/libwireshark0.symbols        |    1 +
 epan/filter_expressions.c           |   12 ++++++++++++
 epan/filter_expressions.h           |   17 +++++++++++++++++
 epan/prefs.c                        |    7 +++++++
 ui/gtk/filter_expression_save_dlg.c |   14 ++------------
 ui/gtk/main.c                       |    1 -
 6 files changed, 39 insertions(+), 13 deletions(-)