Wireshark · Wireshark-commits: [Wireshark-commits] master b3f3dd8: Qt: Fix preference change behavior.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b3f3dd8d82d9b651f34886a3293056c612958aa2
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b3f3dd8 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fix preference change behavior.
    
    Main window:
    
    Keep track of our current layout and only change it if the preferences
    change. This keeps the panes from resizing.
    
    Re-select the current packet if the layout changes so that the proto
    tree and byte view aren't left in an invalid state. This fixes a crash
    similar to bug 10896.
    
    Search frame:
    
    Get rid of an invalid error message. Update coding style.
    
    I don't think any of these fix bug 10921 since Xiaochuan seems to get a
    crash immediately upon opening the dialog.
    
    Change-Id: I0e880a50d3c9ac1c6ae6a01034b05fd2249444f4
    Reviewed-on: https://code.wireshark.org/review/6989
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  3b3ce87   qnet6: Fix a bug found by MSVC2013 Code Analysis.
    adds  b3f3dd8   Qt: Fix preference change behavior.


Summary of changes:
 ui/qt/main_window.cpp       |    1 +
 ui/qt/main_window.h         |    1 +
 ui/qt/main_window_slots.cpp |   12 +++++++
 ui/qt/search_frame.cpp      |   79 ++++++++++++++++++++++---------------------
 ui/qt/search_frame.h        |    6 ++--
 5 files changed, 58 insertions(+), 41 deletions(-)