Wireshark-commits: [Wireshark-commits] master 797ea88: Make get_manuf_name return a const string.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Feb 2015 07:36:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=797ea88aefc2f45dba7e77d2dcaebe68ac1a4fac
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

797ea88 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Make get_manuf_name return a const string.
    
    Model get_manuf_name after get_ether_name so that a string (either name resolved or colon-separated bytes) is always stored in a hash table.  This will make name resolution of addresses perform a little better because it doesn't have to work about the wmem_allocator.
    
    Change-Id: I80f465ae0845290255a659ab63310ac3cc35506e
    Reviewed-on: https://code.wireshark.org/review/7075
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  297ef07   "Hide" hashether_t structure.
    adds  797ea88   Make get_manuf_name return a const string.


Summary of changes:
 debian/libwireshark0.symbols  |    1 +
 epan/addr_resolv.c            |  116 +++++++++++++++++++++++++++--------------
 epan/addr_resolv.h            |    8 ++-
 epan/address_types.c          |   10 ++--
 epan/dissectors/packet-nhrp.c |    4 +-
 ui/gtk/addr_resolution_dlg.c  |    4 +-
 6 files changed, 92 insertions(+), 51 deletions(-)