Wireshark-commits: [Wireshark-commits] master-1.12 f49ab95: epan: fix build error with gcc5
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Feb 2015 09:11:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f49ab95a0b47dd7e5ae0cbdd1ac3ce820c5c753a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

f49ab95 by Daniel Mack (daniel@xxxxxxxxxx):

    epan: fix build error with gcc5
    
    gcc5 bails out with the below error.
    
      CC       libwireshark_la-tvbparse.lo
      CC       libwireshark_la-tvbuff_base64.lo
    tvbparse.c: In function 'cond_not_char':
    tvbparse.c:254:18: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
         if (! offset < tt->end_offset ) {
                      ^
    cc1: all warnings being treated as errors
    Makefile:1843: recipe for target 'libwireshark_la-tvbparse.lo' failed
    
    Change-Id: I4e8654e97079da6b39be580fc766eecefb4c7ea6
    Reviewed-on: https://code.wireshark.org/review/7339
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit b125feae219aaa7afcd10a96a50863cdd83f5bd2)
    Reviewed-on: https://code.wireshark.org/review/7341
    

Actions performed:

    from  bb85d50   ui/gtk: use GTK+ 2 name for control keys
    adds  f49ab95   epan: fix build error with gcc5


Summary of changes:
 epan/tvbparse.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)