Wireshark · Wireshark-commits: [Wireshark-commits] master c8f6d21: Add a dissector for Microsoft's SSTP protocol.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c8f6d2151d8c998b07cba5a0f85c9b9d265b73f8
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c8f6d21 by Hofer Manuel (manuel@xxxxxxxxx):

    Add a dissector for Microsoft's SSTP protocol.
    
    ... with some changes from Jeff Morriss:
    - Change how SSTP is "registered": rather than trying something complicated,
      just put the intelligence for recognizing SSTP into the HTTP dissector.
      (This does mean the SSTP dissector needs to do its own desegmentation now
      but it makes things much cleaner.)
    - Use proto_tree_add_subtree_format() instead of proto_tree_add_text() +
      proto_item_add_subtree().
    - The messagetype is 16 bits, use tvb_get_guint16() instead of tvb_get_guint8()
      (fixes COL_INFO display)
    - A few other few misc. cleanups
    
    (I didn't update NEWS because I can no longer build NEWS without adding UTF8
    fancy quotes and so forth.)
    
    Bug: 8239
    Change-Id: I3631ae65f67bea69815ccf43472fdbcac3ca3499
    Reviewed-on: https://code.wireshark.org/review/7227
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ff1c33c   ssl: check for minimal SSLv3/TLS record size
    adds  c8f6d21   Add a dissector for Microsoft's SSTP protocol.


Summary of changes:
 AUTHORS                         |    4 +
 docbook/release-notes.asciidoc  |    1 +
 epan/CMakeLists.txt             |    1 +
 epan/dissectors/Makefile.common |    1 +
 epan/dissectors/packet-http.c   |   23 +-
 epan/dissectors/packet-sstp.c   |  528 +++++++++++++++++++++++++++++++++++++++
 6 files changed, 554 insertions(+), 4 deletions(-)
 create mode 100644 epan/dissectors/packet-sstp.c