Wireshark-commits: [Wireshark-commits] master 2d48179: Qt: Automatically scroll the packet list.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 27 Feb 2015 20:27:19 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2d4817966ee88d2b163dca46e4df75e8f6262b7a
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2d48179 by Michal Labedzki (michal.labedzki@xxxxxxxxx):

    Qt: Automatically scroll the packet list.
    
    Add an "Auto Scroll in Live Capture" action to the Go menu. It's in the
    View menu in the GTK+ UI but it seems to make more sense as a navigation
    item.
    
    Use a timeout interval for automatic scrolling. I haven't run any tests
    to see if this makes a difference but it would seem that the less
    drawing we do during a high speed capture the better, particularly for
    remote displays.
    
    Update the x-stay-last icons.
    
    Note that we might want to make prefs.capture_auto_scroll a "recent"
    setting.
    
    Mark auto_scroll_live and packet_list_check_end GTK+ only.
    
    Bug: 10601
    Co-authored-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Change-Id: I645d27c0814f0e4a0d5b01ae68be366847e2522d
    Reviewed-on: https://code.wireshark.org/review/7292
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  2462c0d   Use VCINSTALLDIR environment variable in order to locate MSVCR_DLL. This fixes Windows build in cases when MSVS is installed in non-default directory.
    adds  2d48179   Qt: Automatically scroll the packet list.


Summary of changes:
 epan/prefs.c                           |    1 +
 file.c                                 |    2 +-
 image/toolbar/16x16/x-stay-last.png    |  Bin 267 -> 303 bytes
 image/toolbar/16x16/x-stay-last.svg    |   44 ++++++++++++++------
 image/toolbar/16x16/x-stay-last@xxxxxx |  Bin 425 -> 380 bytes
 image/toolbar/24x24/x-stay-last.png    |  Bin 295 -> 313 bytes
 image/toolbar/24x24/x-stay-last.svg    |   46 ++++++++++++++-------
 image/toolbar/24x24/x-stay-last@xxxxxx |  Bin 479 -> 408 bytes
 ui/preference_utils.h                  |    2 +-
 ui/qt/capture_file.cpp                 |    1 +
 ui/qt/main_window.cpp                  |   14 ++++---
 ui/qt/main_window.h                    |    3 +-
 ui/qt/main_window.ui                   |   14 +++++++
 ui/qt/main_window_slots.cpp            |   10 ++++-
 ui/qt/packet_list.cpp                  |   70 ++++++++++++++++++++++++++++----
 ui/qt/packet_list.h                    |   16 +++++++-
 ui/ui_util.h                           |    2 +-
 17 files changed, 177 insertions(+), 48 deletions(-)