Wireshark · Wireshark-commits: [Wireshark-commits] master 9ac60ff: address_to_string routines need to remember the beginning of the

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9ac60ff0df25765612d219dcaa7fe1210f6e0bcd
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9ac60ff by Guy Harris (guy@xxxxxxxxxxxx):

    address_to_string routines need to remember the beginning of the buffer.
    
    Either they don't have a pointer into the buffer that they advance, in
    which case strlen(buf)+1 works just fine, or they do, in which case
    
    	1) they'd better save the pointer to the beginning of the
    	   buffer, so they can figure out how long the string is when
    	   they're done
    
    and
    
    	2) they don't need to use strlen(), they can just subtract the
    	   pointers.
    
    Bug: 11016
    Change-Id: I81ce9d517336a15bd81f0c6225756ce5178ec6cf
    Reviewed-on: https://code.wireshark.org/review/7424
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1e66e74   Add dissector for "Bad Password Threshold" IPMI LAN configuration parameter.
    adds  9ac60ff   address_to_string routines need to remember the beginning of the buffer.


Summary of changes:
 epan/address_types.c |   55 +++++++++++++++++++++++++++-----------------------
 1 file changed, 30 insertions(+), 25 deletions(-)