Wireshark-commits: [Wireshark-commits] master d488d63: ssl-utils: refactor keyfile matching
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 23 Feb 2015 11:47:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d488d6392a9686ef1b27019c573dc422a525b9ee
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d488d63 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: refactor keyfile matching
    
    Merge the three separate regexes into a single pattern and use named
    groups. This avoid magic numbers (group positions) and removes a
    possible error source when the ht array gets out of sync with the
    patterns array (by human error).
    
    This is supposed to be more readable and allows for easier extension of
    the regex.
    
    Change-Id: I816525f358cdb89ff9f8ebc1211139b1f8c23840
    Reviewed-on: https://code.wireshark.org/review/7245
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Petri-Dish: Evan Huus <eapache@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  306c819   jmirror packet dissector expects ipv6 flow label = 0
    adds  d488d63   ssl-utils: refactor keyfile matching


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |  120 ++++++++++++++++++------------------
 1 file changed, 61 insertions(+), 59 deletions(-)