Wireshark-commits: [Wireshark-commits] master 7263af8: Eliminate some DIRTY_ file lists.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Feb 2015 08:04:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7263af87c6b0019c1bfda0f66fdc991330941892
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7263af8 by Guy Harris (guy@xxxxxxxxxxxx):

    Eliminate some DIRTY_ file lists.
    
    We don't want to encourage people to add to those lists, we want to
    encourage people to subtract *from* those lists (either by fixing
    warnings or, if an infelicitous API, or an infelicitous declaration of
    an API on some platforms, or a program generator that doesn't take
    sufficient care to avoid warnings - I'm looking at *you*, Flex - makes
    it impossible to fix without introducing other problems, using the
    DIAG_OFF()/DIAG_ON() macros if possible).  Eliminate the empty lists, to
    make it harder to fill them up again.
    
    Change-Id: I298d07952c0cb1842a4ea71ba7e07c68e94a04e9
    Reviewed-on: https://code.wireshark.org/review/7229
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  9707ff8   Uninstall wireshark.appdata.xml.
    adds  7263af8   Eliminate some DIRTY_ file lists.


Summary of changes:
 ui/cli/Makefile.common |    5 +----
 ui/gtk/CMakeLists.txt  |    4 ----
 ui/qt/CMakeLists.txt   |   11 +++--------
 wiretap/CMakeLists.txt |   12 ++----------
 4 files changed, 6 insertions(+), 26 deletions(-)