Wireshark-commits: [Wireshark-commits] master a355daf: Give users a more helpful error message if t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Feb 2015 14:08:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a355daf328d9c07947565a6f0f07a4407f4367c8
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a355daf by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Give users a more helpful error message if they enter an SSL protocol we don't
    know.
    
    First, if we know the protocol (by filter name) tell them that the dissector
    just isn't set up to run over SSL but it could be--if they contact the Wireshark
    developers.
    
    Second, don't tell them that the dissectors which have called
    ssl_dissector_add() are the only ones that are valid; those are just commonly
    used ones.
    
    Change-Id: I1b72bccd4c96c21c73a19fa2d87fe2c0b875a0fa
    Reviewed-on: https://code.wireshark.org/review/7185
    Reviewed-by: Richard Sharpe <realrichardsharpe@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  0da88ba   Don't send an effectively empty message (no TVBs) to the SCTP tap.
    adds  a355daf   Give users a more helpful error message if they enter an SSL protocol we don't know.


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)