Wireshark-commits: [Wireshark-commits] master b635997: Convert val_to_str_ext -> val_to_str_ext_wme
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 3 Feb 2015 13:03:36 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b63599762468e4cf1783419a5556377604d344bb
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b635997 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Convert val_to_str_ext -> val_to_str_ext_wmem for calls that don't have valid packet scope (GUI).
    val_to_str_ext now officially uses wmem_packet_scope().
    
    Removed const from val_to_str[_ext]_wmem return value since it's not really constant.
    
    Created utility functions in qt_ui_utils.h to help with the new memory management for its GUI.
    
    Change-Id: Idf2ce4a4ce78d628b2269ad23a3a48fbfc9c077c
    Reviewed-on: https://code.wireshark.org/review/6926
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e942973   Bluetooth/USB HID: Move boot form of reports from bthid to usbhid
    adds  b635997   Convert val_to_str_ext -> val_to_str_ext_wmem for calls that don't have valid packet scope (GUI). val_to_str_ext now officially uses wmem_packet_scope().


Summary of changes:
 epan/value_string.c         |   10 ++++-----
 epan/value_string.h         |    4 ++--
 ui/cli/tap-afpstat.c        |    5 ++++-
 ui/cli/tap-rtp.c            |    8 ++++----
 ui/cli/tap-scsistat.c       |    7 +++++--
 ui/cli/tap-smbstat.c        |   14 ++++++++++---
 ui/gtk/afp_stat.c           |    4 +++-
 ui/gtk/rtp_stream_dlg.c     |   28 +++++++++++--------------
 ui/gtk/scsi_stat.c          |    4 +++-
 ui/gtk/smb2_stat.c          |    4 +++-
 ui/gtk/smb_stat.c           |   12 ++++++++---
 ui/qt/qt_ui_utils.cpp       |   20 ++++++++++++++++++
 ui/qt/qt_ui_utils.h         |   21 +++++++++++++++++++
 ui/qt/rtp_stream_dialog.cpp |    2 +-
 ui/voip_calls.c             |   48 ++++++++++++++++++++++---------------------
 15 files changed, 128 insertions(+), 63 deletions(-)