Wireshark-commits: [Wireshark-commits] master 770ac91: Qt: Fix a crash when changing the layout.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Feb 2015 00:42:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=770ac9123b9c74e2325b39c5af04455dd14f2aba
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

770ac91 by Gerald Combs (gerald@xxxxxxxx):

    Qt: Fix a crash when changing the layout.
    
    Freeze and thaw the packet list when changing the layout. This has the
    side effect of clearing the proto tree and byte view, which avoids
    reading a bad tvb pointer. Note that we might want to add a cleanup
    callback to free_data_sources.
    
    Save and restore the current row. Add CaptureFile::currentRow. Fix a
    couple of comparisons in PacketList.
    
    Change-Id: I26f9b97ae5a7cdb4fb6e5e6e675570884900e995
    Reviewed-on: https://code.wireshark.org/review/7337
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  a6f4bdb   pcap-common: fix build error with gcc5
    adds  770ac91   Qt: Fix a crash when changing the layout.


Summary of changes:
 ui/qt/byte_view_tab.cpp     |    4 ++++
 ui/qt/capture_file.cpp      |    7 +++++++
 ui/qt/capture_file.h        |    7 +++++++
 ui/qt/main_window_slots.cpp |    7 ++++---
 ui/qt/packet_list.cpp       |    4 ++--
 5 files changed, 24 insertions(+), 5 deletions(-)