Wireshark-commits: [Wireshark-commits] master 931807e: Qt: Add the "new packet" window^Wdialog^Wwin
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Feb 2015 23:32:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=931807ea61cd9b2729fa06fefa6ce3a09b89ee4b
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

931807e by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Add the "new packet" window^Wdialog^Wwindow.
    
    Allow persistence across files. Preserve the use of "window" even
    though we're really a dialog.
    
    Update ByteViewTab and ProtoTree to support multiple instances.
    
    Remove the need for a cast in frame_data.
    
    Add more forward declarations.
    
    Change-Id: I50d3d9d1455b8ecc158a37218f9e41fe696d5ae2
    Reviewed-on: https://code.wireshark.org/review/7086
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  b3e2c56   Docbook: Don't build PDF release notes by default.
    adds  931807e   Qt: Add the "new packet" window^Wdialog^Wwindow.


Summary of changes:
 epan/frame_data.h                                  |    2 +-
 ui/help_url.c                                      |    4 +-
 ui/help_url.h                                      |    3 +-
 ui/qt/CMakeLists.txt                               |    3 +
 ui/qt/Makefile.am                                  |    2 +
 ui/qt/Makefile.common                              |    4 +
 ui/qt/Wireshark.pro                                |    3 +
 ui/qt/byte_view_tab.cpp                            |    2 +
 ui/qt/main_window.cpp                              |    4 +-
 ui/qt/main_window.h                                |   15 +-
 ui/qt/main_window.ui                               |   18 ++-
 ui/qt/main_window_slots.cpp                        |   35 ++++-
 ui/qt/packet_dialog.cpp                            |  163 ++++++++++++++++++++
 ui/qt/{file_set_dialog.h => packet_dialog.h}       |   51 +++---
 ...{compiled_filter_output.ui => packet_dialog.ui} |   59 ++++---
 ui/qt/packet_list.cpp                              |    6 +-
 ui/qt/proto_tree.cpp                               |  103 +++++++------
 wireshark-qt.cpp                                   |    1 +
 18 files changed, 362 insertions(+), 116 deletions(-)
 create mode 100644 ui/qt/packet_dialog.cpp
 copy ui/qt/{file_set_dialog.h => packet_dialog.h} (61%)
 copy ui/qt/{compiled_filter_output.ui => packet_dialog.ui} (51%)