Wireshark-commits: [Wireshark-commits] master-1.12 be37246: Don't send an effectively empty message
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 17 Feb 2015 14:48:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be37246160bf5dd588d146fa348cba63200baa90
Submitter: Jeff Morriss (jeff.morriss.ws@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

be37246 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Don't send an effectively empty message (no TVBs) to the SCTP tap.
    
    This prevents the tap from crashing (asserting out) because there's no
    (initialized) TVB to look at.
    
    Bug: 9849
    Change-Id: I370a49ef32a67e504c30cf1762a2180bf13c56ca
    Reviewed-on: https://code.wireshark.org/review/7190
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 0da88ba505188518a1b9ba055ccfc5e01d4ec505)
    Reviewed-on: https://code.wireshark.org/review/7194
    Reviewed-by: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    

Actions performed:

    from  c067619   Revert "Fix duplicate Display Filter Macro check"
    adds  be37246   Don't send an effectively empty message (no TVBs) to the SCTP tap.


Summary of changes:
 epan/dissectors/packet-sctp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)