Wireshark-commits: [Wireshark-commits] master 5403478: refactor the dissection of USB setup request
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 7 Feb 2015 18:19:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=540347850fce692b8789220344b0a8978dd82e62
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5403478 by Martin Kaiser (wireshark@xxxxxxxxx):

    refactor the dissection of USB setup requests
    
    pass the data only to one subsequent dissection function
    either we have a standard request or a non-standard request that can be
    handled by a class dissector (we used to do both at the same time,
    this makes the output difficult to read)
    
    Change-Id: Ia46239b2b9e121c9ca165cc56d0b271345d7962e
    Reviewed-on: https://code.wireshark.org/review/7005
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  a097659   change try_dissect_next_protocol() such that its parameter is the top-most tree on which it operates
    adds  5403478   refactor the dissection of USB setup requests


Summary of changes:
 epan/dissectors/packet-usb.c |   75 ++++++++++++++++++++++++++----------------
 1 file changed, 47 insertions(+), 28 deletions(-)