Wireshark-commits: [Wireshark-commits] master 859511d: Make UAT record update callbacks return a su
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Feb 2015 00:41:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=859511db14feae071cc1e6e1889ae39bfd276faa
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

859511d by Guy Harris (guy@xxxxxxxxxxxx):

    Make UAT record update callbacks return a success/failure indication.
    
    Have them return TRUE on success and FALSE on failure.  Check the return
    value rather than whether the error string pointer is null or not.
    
    Change-Id: I800a03bcd70a6bbb7b217cf7c4800e9cdcf2189c
    Reviewed-on: https://code.wireshark.org/review/7222
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  3f765b3   Add a CF_FUNC macro for casting BASE_CUSTOM functions.
    adds  859511d   Make UAT record update callbacks return a success/failure indication.


Summary of changes:
 asn1/c1222/packet-c1222-template.c     |    6 ++-
 epan/dfilter/dfilter-macro.c           |    4 +-
 epan/dissectors/packet-bootp.c         |    7 +++-
 epan/dissectors/packet-c1222.c         |   12 ++++--
 epan/dissectors/packet-devicenet.c     |    7 +++-
 epan/dissectors/packet-http.c          |    9 +++--
 epan/dissectors/packet-ieee80211.c     |   67 ++++++++++++++++++--------------
 epan/dissectors/packet-ieee802154.c    |    9 +++--
 epan/dissectors/packet-imf.c           |    9 +++--
 epan/dissectors/packet-ipsec.c         |    3 +-
 epan/dissectors/packet-isakmp.c        |   25 ++++++------
 epan/dissectors/packet-k12.c           |    5 ++-
 epan/dissectors/packet-lbmpdmtcp.c     |    5 ++-
 epan/dissectors/packet-lbmr.c          |    5 ++-
 epan/dissectors/packet-lbtrm.c         |    5 ++-
 epan/dissectors/packet-lbtru.c         |    5 ++-
 epan/dissectors/packet-lbttcp.c        |    5 ++-
 epan/dissectors/packet-pdcp-lte.c      |    4 +-
 epan/dissectors/packet-sccp.c          |    9 +++--
 epan/dissectors/packet-sctp.c          |    9 +++--
 epan/dissectors/packet-vcdu.c          |    5 ++-
 epan/dissectors/packet-zbee-nwk-gp.c   |    6 ++-
 epan/dissectors/packet-zbee-security.c |    6 ++-
 epan/expert.c                          |    4 +-
 epan/uat.h                             |   31 ++++++++++-----
 epan/uat_load.l                        |   11 +++---
 plugins/stats_tree/pinfo_stats_tree.c  |    5 ++-
 ui/gtk/uat_gui.c                       |    4 +-
 28 files changed, 175 insertions(+), 107 deletions(-)