Wireshark-commits: [Wireshark-commits] master 0ed1b0f19: Add ws_mempbrk_sse42_compile to Valgrind s
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 15 Feb 2015 18:46:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0ed1b0f1947965982044787b09d7a0891d3ef438
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0ed1b0f19 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Add ws_mempbrk_sse42_compile to Valgrind suppression list
    
    When running Valgrind 3.10.0 on an Ubuntu 10.10 x64 guest with Virtualbox 4.3.22, ws_cpuid_sse42() call triggers a false positive when checking ECX bit 20
    Guy kindly verified the assembler code and confirmed that everything seems fine
    Let's remove the error to avoid noise when running Valgrind on a capture
    Change-Id: I357633950249a0c781482865c3221a1babdc74e2
    Reviewed-on: https://code.wireshark.org/review/7124
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  e326318   Only call tvb_get_ptr() once to set src and dst addresses-
    adds  0ed1b0f19 Add ws_mempbrk_sse42_compile to Valgrind suppression list


Summary of changes:
 tools/vg-suppressions |   10 ++++++++++
 1 file changed, 10 insertions(+)