Wireshark-commits: [Wireshark-commits] master d1865e0: Make FT_{U}INT{40, 48, 56, 64} handle BASE_C
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Feb 2015 08:56:48 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d1865e000ebedf49fc0d9f221a11d6af74360837
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d1865e0 by Guy Harris (guy@xxxxxxxxxxxx):

    Make FT_{U}INT{40,48,56,64} handle BASE_CUSTOM.
    
    Finish the job of handling integral values > 32 bits similarly to who we
    handle values 32 bits or less.
    
    In cases that "should not happen", and where we might *not* be executing
    in the context of a dissector (filling in the field label can be done
    lazily, being deferred to "print" time, and that doesn't happen in the
    context of a dissector), use g_assert_not_reached() rather than
    DISSECTOR_ASSERT_NOT_REACHED() - the latter throws an assertion that's
    not caught if we're not doing dissection, so we crash anyway.
    
    Bug: 10983
    Change-Id: Ia81a0a4925394f99aa35193a333f3e9659a9b93d
    Reviewed-on: https://code.wireshark.org/review/7307
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  1157aa8   Set 64-bit signed values with proto_tree_set_int64().
    adds  d1865e0   Make FT_{U}INT{40,48,56,64} handle BASE_CUSTOM.


Summary of changes:
 epan/proto.c |  108 +++++++++++++---------------------------------------------
 1 file changed, 23 insertions(+), 85 deletions(-)