Wireshark-commits: [Wireshark-commits] master 30651ab: DNS: Ignore Client Subnet option's data leng
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Feb 2015 06:34:50 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=30651ab18b42e666f57ea239e58f3ff3a5e9c4ad
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

30651ab by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    DNS: Ignore Client Subnet option's data length when > 16
    
    When DNS Client Subnet length is > 16, the limit coming from avoid stack smashing with tvb_memcpy
    
    Issue reported by Boaz
    
    Bug:10988
    Change-Id: I6103ba47fac9817410c7fc399c18e96c66ab8438
    Reviewed-on: https://code.wireshark.org/review/7308
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b9af5a5   proto.c: avoid corrupting stack when printing a 64 bits field in BASE_DEC_HEX or BASE_HEX_DEC format
    adds  30651ab   DNS: Ignore Client Subnet option's data length when > 16


Summary of changes:
 epan/dissectors/packet-dns.c |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)