Wireshark-commits: [Wireshark-commits] master b9296b7: Fix handling of longitude and latitude value
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Feb 2015 20:22:11 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b9296b721f2e819f4243f100e102489c7ac4d718
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b9296b7 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of longitude and latitude values.
    
    The formatting routine is getting passed the 5-byte value, not some
    8-byte value that includes the 3 bytes after it, so shifting it produces
    the wrong value.
    
    Make the longitude and latitude FT_UINT40, as they're only 5 bytes long.
    
    Change-Id: I35aa05887bcfdfc1107fef2ac5069f1fe96fda3a
    Reviewed-on: https://code.wireshark.org/review/7321
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  08bee7d   Clean up display of raw hex latitude/longitude values.
    adds  b9296b7   Fix handling of longitude and latitude values.


Summary of changes:
 epan/dissectors/packet-lldp.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)