Wireshark-commits: [Wireshark-commits] master 96527e2: riemann: Fix bug found by MSVC203 Code Analy
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 7 Feb 2015 21:33:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=96527e24e8e10a707c51c48f52233453c3056702
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

96527e2 by Bill Meier (wmeier@xxxxxxxxxxx):

    riemann: Fix bug found by MSVC203 Code Analysis
    
    The following doesn't quite do what it might seem to be doing:
        guint64 num;
        guint8 b;
        num |= ((b & 0x7f) << shift);
    
    The warning from MSVC2013:
     Arithmetic overflow:  32-bit value is shifted, then cast to 64-bit
      value. Results might not be an expected value
    
    Change-Id: Ic8c939355b54317f0b459c60342f3cb5dfa29624
    Reviewed-on: https://code.wireshark.org/review/7015
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  22b4619   Add the profile name to the Coloring Rules window title.
    adds  96527e2   riemann: Fix bug found by MSVC203 Code Analysis


Summary of changes:
 epan/dissectors/packet-riemann.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)