Wireshark-commits: [Wireshark-commits] master c96b3ac: AMQP 0-9-1: Fix dissection of field types.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 2 Feb 2015 20:59:42 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c96b3ac999df1fc8dadee51d2bb4ec45fc345805
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c96b3ac by Petr Gotthard (petr.gotthard@xxxxxxxxxx):

    AMQP 0-9-1: Fix dissection of field types.
    
    This patch resolves review comments I received from the AMQP 0-9-1 community.
    Some field types were not implemented, other field types (introduced by my
    earlier patch) were incorrectly parsed.
    https://groups.google.com/forum/#!topic/rabbitmq-users/PR7P1bgonwo
    
    I had to split the dissect_amqp_0_9_field_table() function into two parts
    and put the field value dissectors in a separate function:
    dissect_amqp_0_9_field_value().
    
    Change-Id: I9aa7d73e426a790830ad260ca6892a7650791e6c
    Reviewed-on: https://code.wireshark.org/review/6882
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  9f4bf6a   LTE RRC: only display band mapping for the initial supportedBandListEUTRA IE
    adds  c96b3ac   AMQP 0-9-1: Fix dissection of field types.


Summary of changes:
 epan/dissectors/packet-amqp.c |  505 ++++++++++++++++++++++++-----------------
 1 file changed, 295 insertions(+), 210 deletions(-)