Wireshark-commits: [Wireshark-commits] master 2078a95: pgsql, imap: add STARTTLS support
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 9 Feb 2015 16:26:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2078a95e934cf1063f2525a93b5f81ddb7b43e77
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2078a95 by Peter Wu (peter@xxxxxxxxxxxxx):

    pgsql,imap: add STARTTLS support
    
    The PGSQL "STARTTLS" protocol is documented at
    http://www.postgresql.org/docs/9.4/static/protocol-flow.html
    While at it, convert some tvb_length[_remaining] users.
    
    Tested against pgsql-ssl.pcapng,
    Tested against imap-ssl.pcapng,
    http://wiki.wireshark.org/SampleCaptures#SSL_with_decryption_keys
    
    Change-Id: I1a00a6daa7f03de93339c2c13b07b4cfb8cdbd86
    Reviewed-on: https://code.wireshark.org/review/6821
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  a58cf52   file-jpeg: Allow 'Exif' as identification in first App block, but flag as expert info warning if seen
    adds  2078a95   pgsql,imap: add STARTTLS support


Summary of changes:
 epan/dissectors/packet-imap.c  |   47 ++++++++++++++++++++++++++------
 epan/dissectors/packet-pgsql.c |   59 ++++++++++++++++++++++++++++++++--------
 2 files changed, 86 insertions(+), 20 deletions(-)