Wireshark-commits: [Wireshark-commits] master 33f1256: Fix nameless application in NokiaSolutionsAn
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 3 Feb 2015 05:59:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=33f1256e00d4d91a7726fee0847144d4b6ba088b
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

33f1256 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Fix nameless application in NokiaSolutionsAndNetworks.xml (from
    I4cd9bd7f7219e4d9ff1bb8a71fab32439a8a9a35).
    
    (The nameless application was causing known applications to be reported as
    unknown.)
    
    Add code to the Diameter dissector to report such problems at startup (similar
    code exists for other entities).
    
    Tweak the parser debug slightly.
    
    Change-Id: I6b28cda8660e6eb96648c7b3697d7fd85151ac96
    Reviewed-on: https://code.wireshark.org/review/6927
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  00f7bc4   Qt: Fix IO Graph capture file closing.
    adds  33f1256   Fix nameless application in NokiaSolutionsAndNetworks.xml (from I4cd9bd7f7219e4d9ff1bb8a71fab32439a8a9a35).


Summary of changes:
 diameter/NokiaSolutionsAndNetworks.xml |    2 +-
 diameter/dictionary.xml                |    2 +-
 epan/diam_dict.l                       |    4 ++--
 epan/dissectors/packet-diameter.c      |    7 ++++++-
 4 files changed, 10 insertions(+), 5 deletions(-)