Wireshark-commits: [Wireshark-commits] master 3b29542: Add a "Sum" column to the Service Response T
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3b2954208a060eba500cb48c14ec6a4fe4a99494
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
3b29542 by Kevin Grigorenko (kevin.grigorenko@xxxxxxxxxx):
Add a "Sum" column to the Service Response Time (SRT) window.
The Service Response Time (SRT) window currently provides the
columns: Index, Procedure, Calls, Min SRT, Max SRT, and Avg SRT.
A Sum column has been found useful in some customer situations
to understand the total time spent doing a set of procedures.
For example, in one case we were trying to isolate whether most
time was being spent on a client thread or in the act of making
outbound calls. We knew the start and end time of the client call,
so with the "Sum" of time spent in that period, we could isolate
a particular set of procedures driving the slow down.
Additional changes made in this patch:
* Add " (s)" to Min, Max, Avg, and Sum columns to make it clear
that times are in seconds.
* Refactor out width and height constants used in calls to
gtk_window_set_default_size in most of the SRT users into
#define SRT_PREFERRED_WIDTH and SRT_PREFERRED_HEIGHT. Also
increase the common width of 550 to 650 to account for the
additional column.
Change-Id: I20f152eecbcd0bbf69f71c6c6b9f9463e8867e23
Reviewed-on: https://code.wireshark.org/review/7047
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 895b013 Use G_GINT64_MODIFIER when formatting g{u}int64 values.
adds 3b29542 Add a "Sum" column to the Service Response Time (SRT) window.
Summary of changes:
ui/gtk/afp_stat.c | 2 +-
ui/gtk/camel_srt.c | 2 +-
ui/gtk/compare_stat.c | 2 +-
ui/gtk/dcerpc_stat.c | 2 +-
ui/gtk/diameter_stat.c | 2 +-
ui/gtk/fc_stat.c | 2 +-
ui/gtk/gtp_stat.c | 2 +-
ui/gtk/ldap_stat.c | 2 +-
ui/gtk/rpc_stat.c | 2 +-
ui/gtk/scsi_stat.c | 2 +-
ui/gtk/service_response_time_table.c | 11 +++++++++--
ui/gtk/service_response_time_table.h | 6 ++++++
ui/gtk/smb2_stat.c | 2 +-
ui/gtk/smb_stat.c | 2 +-
14 files changed, 27 insertions(+), 14 deletions(-)
