| February 01, 2017 |
|---|
| 02:31 |
[Wireshark-commits] master fcf2eb4: Openflow (v5): fix redundant redeclaration of ‘dissect_openflow_message_v5’ [-Wredundant-decls] |
Wireshark code review |
|
| 02:50 |
[Wireshark-commits] master e25c458: ssl-utils: fix format specifies type 'void *' but the argument has type 'SslFlow *' (aka 'struct _SslFlow *') [-Wformat-pedantic] |
Wireshark code review |
|
| 04:37 |
[Wireshark-commits] master 2b91f04: sharkd: windows support |
Wireshark code review |
|
| 04:43 |
[Wireshark-commits] master 11ce17f: Expand a comment to give more details. |
Wireshark code review |
|
| 07:36 |
[Wireshark-commits] master 20bce6f: packet-btle.c: If frame information is missing, provide a default. |
Wireshark code review |
|
| 07:37 |
[Wireshark-commits] master 2755942: Bluetooth 5.0, HCI command/event PHY update dissection |
Wireshark code review |
|
| 08:59 |
[Wireshark-commits] master 5dde07c: GSM A / NAS-EPS: detect missing mandatory information elements |
Wireshark code review |
|
| 13:41 |
[Wireshark-commits] master bf14d8f: dtls: avoid possible NULL deref |
Wireshark code review |
|
| 16:08 |
[Wireshark-commits] master 57d2705: ndps: convert GHashtable to wmem_map. |
Wireshark code review |
|
| 16:09 |
[Wireshark-commits] master 401a20d: ieee802a: add shutdown routine. |
Wireshark code review |
|
| 16:10 |
[Wireshark-commits] master 2cdc1ec: proto: free memory on cleanup. |
Wireshark code review |
|
| 16:11 |
[Wireshark-commits] master 0a200b2: hdcp2: convert GHashTable to wmem_map. |
Wireshark code review |
|
| 16:12 |
[Wireshark-commits] master add6cb3: ipmi: use wmem instead of glib allocator. |
Wireshark code review |
|
| 16:14 |
[Wireshark-commits] master 96b8da7: h248: convert GTree to wmem_tree. |
Wireshark code review |
|
| 16:15 |
[Wireshark-commits] master 226377f: h460: use wmem for strdup. |
Wireshark code review |
|
| 18:16 |
[Wireshark-commits] master ed6c961: frame: use wmem instead of glib allocator. |
Wireshark code review |
|
| 18:19 |
[Wireshark-commits] master c46ea01: Fix some more UN*X-vs-Windows issues. |
Wireshark code review |
|
| 19:06 |
[Wireshark-commits] master 28d7753: Use INVALID_SOCKET for an invalid socket handle. |
Wireshark code review |
|
| February 02, 2017 |
|---|
| 01:14 |
[Wireshark-commits] master bd3c2d2: Make some more protocols into pinos. |
Wireshark code review |
|
| 01:55 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 10:34 |
[Wireshark-commits] master efb5c15: Qt: Add extcap placeholder parameter |
Wireshark code review |
|
| 12:42 |
[Wireshark-commits] master 3026652: tools: add a Gtk/GNOME suppression file. |
Wireshark code review |
|
| 12:58 |
[Wireshark-commits] master 36892d8: iso15765: convert GHashTable to wmem_map. |
Wireshark code review |
|
| 13:46 |
[Wireshark-commits] master 577d21e: GHashtable -> wmem_map conversions |
Wireshark code review |
|
| 14:26 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 15:34 |
[Wireshark-commits] master c0d25e8: ncp: convert GHashTable to wmem_map_t. |
Wireshark code review |
|
| 16:11 |
[Wireshark-commits] master 47ad059: Rawshark: Add a memory limit (-m) option. |
Wireshark code review |
|
| 16:48 |
[Wireshark-commits] master 179e0fb: imf: convert GHashTable to wmem_map |
Wireshark code review |
|
| 17:46 |
[Wireshark-commits] master f6e8894: sharkd: make it compile without libGeoIP. |
Wireshark code review |
|
| 21:02 |
[Wireshark-commits] master f15d5dd: xml: use wmem allocators and replace GHashTable with wmem_map_t. |
Wireshark code review |
|
| 21:14 |
[Wireshark-commits] master 7893ffa: wsutil/sober128: remove unused macros and functions |
Wireshark code review |
|
| 21:15 |
[Wireshark-commits] master 0da95c1: dtls: Support Decode As for selecting appdata dissector |
Wireshark code review |
|
| 21:19 |
[Wireshark-commits] master 844cf1a: NFSv4.2 mode_umask support |
Wireshark code review |
|
| 21:42 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 22:05 |
[Wireshark-commits] master 93a5c83: capture_opts: free memory on exit to avoid leak. |
Wireshark code review |
|
| 22:58 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| February 03, 2017 |
|---|
| 00:02 |
[Wireshark-commits] master 14fba80: Fix builds without libpcap. |
Wireshark code review |
|
| 00:13 |
[Wireshark-commits] master 6031712: Fix builds without libpcap. |
Wireshark code review |
|
| 01:45 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 02:39 |
[Wireshark-commits] master 370d130: stream: clean up reassembly table. |
Wireshark code review |
|
| 02:40 |
[Wireshark-commits] master 7c69ae9: dfilter-macro: add cleanup routine. |
Wireshark code review |
|
| 02:41 |
[Wireshark-commits] master fe06aad: sharkd: fix warning C4090: 'function' : different 'const' qualifiers |
Wireshark code review |
|
| 11:20 |
[Wireshark-commits] master 3481ca8: extcap: destroy hash tables on exit. |
Wireshark code review |
|
| 11:55 |
[Wireshark-commits] master 1a1e7e4: BTLE: check connection_info presence before trying to perform reassembly |
Wireshark code review |
|
| 14:18 |
[Wireshark-commits] master a3bd605: MKA: Padding support for basic-param-set dissection added |
Wireshark code review |
|
| 14:24 |
[Wireshark-commits] master 22ab065: Add support for Couchbase LWW *_with_meta commands |
Wireshark code review |
|
| 14:43 |
[Wireshark-commits] master 6311657: .mailmap: Update (of december) |
Wireshark code review |
|
| 14:58 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| February 04, 2017 |
|---|
| 01:32 |
[Wireshark-commits] master 92601c4: srt_table: add cleanup function. |
Wireshark code review |
|
| 01:36 |
[Wireshark-commits] master 9a47f5c: conversation_table: replace g_string with wmem allocated string. |
Wireshark code review |
|
| 01:39 |
[Wireshark-commits] master e595836: tap-stats_tree: use wmem allocator. |
Wireshark code review |
|
| 13:26 |
[Wireshark-commits] master 0b25b1a: tap: add cleanup routine. |
Wireshark code review |
|
| 14:06 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 21:27 |
[Wireshark-commits] master 55b3de8: IPv6: Update SRH dissection to draft-*-05 |
Wireshark code review |
|
| 22:42 |
[Wireshark-commits] master 4248a97: There's an RFC for that. |
Wireshark code review |
|
| February 05, 2017 |
|---|
| 13:20 |
[Wireshark-commits] master c7622c9: pint(.h): Add Modelines and fix indent (use spaces) |
Wireshark code review |
|
| 13:24 |
[Wireshark-commits] master fd2bd2b: [GSA RR] Dissect System Information Type 21 |
Wireshark code review |
|
| 13:46 |
[Wireshark-commits] master a8ceeca: DNP3: Fix reassembly of out of order fragments |
Wireshark code review |
|
| 14:04 |
[Wireshark-commits] master c9d8c1c: PDML: protocol filter incorrectly filters desired subfields |
Wireshark code review |
|
| 14:33 |
[Wireshark-commits] master 5511386: iee80211: fix typo on some tag define |
Wireshark code review |
|
| 14:34 |
[Wireshark-commits] master 19f0721: ieee802.11: fix indent |
Wireshark code review |
|
| 16:12 |
[Wireshark-commits] master e35c21c: [Automatic update for 2017-02-05] |
Wireshark code review |
|
| 16:21 |
[Wireshark-commits] master-2.2 e11f69b: [Automatic update for 2017-02-05] |
Wireshark code review |
|
| 16:29 |
[Wireshark-commits] master-2.0 f6e8475: [Automatic update for 2017-02-05] |
Wireshark code review |
|
| 17:32 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 20:26 |
[Wireshark-commits] master a69d0b1: GTK: Add 'in' operator in display filter expression dialog |
Wireshark code review |
|
| 22:16 |
[Wireshark-commits] master 9ffff86: RSVD dissector: minor fixes |
Wireshark code review |
|
| 22:57 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| February 06, 2017 |
|---|
| 09:21 |
[Wireshark-commits] master 60edcb1: Couchbase: Add decoding for create_bucket config |
Wireshark code review |
|
| 12:42 |
[Wireshark-commits] master 5df6983: checkfiltername: Add llc.bluetooth_pid to the whitelist |
Wireshark code review |
|
| 12:53 |
[Wireshark-commits] master 850393b: geoip_db: remove leak. |
Wireshark code review |
|
| 12:54 |
[Wireshark-commits] master cde0937: llc: replace GHashTable and glib allocator with wmem. |
Wireshark code review |
|
| 14:10 |
[Wireshark-commits] master 0eda452: Bluetooth: SDP: Add HDP MDEP Data Type values for ISO/IEEE 11073-20601 |
Wireshark code review |
|
| 14:11 |
[Wireshark-commits] master b774638: Bluetooth: ATT: Implement "Resolvable Private Address" |
Wireshark code review |
|
| 14:45 |
[Wireshark-commits] master 015adf8: rawshark: fix err code. |
Wireshark code review |
|
| 16:09 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 18:22 |
[Wireshark-commits] master 4f532f5: Bluetooth: Update Assign Numbers |
Wireshark code review |
|
| 21:15 |
[Wireshark-commits] master f6b7857: ssl-utils: add helper for validating Variable Length Vectors |
Wireshark code review |
|
| 21:30 |
[Wireshark-commits] master 4623b05: ssl-utils: refactor "length" parameter into "offset_end" for extensions |
Wireshark code review |
|
| 21:31 |
[Wireshark-commits] master 658253b: (D)TLS: simplify SignatureAndHashAlgorithm dissection |
Wireshark code review |
|
| 21:32 |
[Wireshark-commits] master e19084f: ssl-utils: add validation for ALPN |
Wireshark code review |
|
| 21:33 |
[Wireshark-commits] master f3eb00a: ssl-utils: add length validation to NPN extension |
Wireshark code review |
|
| 21:34 |
[Wireshark-commits] master bdbe1e2: ssl-utils: add length validation for renegotiation_info extension |
Wireshark code review |
|
| 21:36 |
[Wireshark-commits] master 6c1d140: ssl-utils: add length validation for Cookie extension |
Wireshark code review |
|
| 21:37 |
[Wireshark-commits] master 420b9e0: ssl-utils: add length validation for SNI extension |
Wireshark code review |
|
| February 07, 2017 |
|---|
| 05:16 |
[Wireshark-commits] master e9cf760: GTK: Wrap static preference labels. |
Wireshark code review |
|
| 05:17 |
[Wireshark-commits] master 912aaf0: Adjust startup count for extcap. |
Wireshark code review |
|
| 05:20 |
[Wireshark-commits] master 5d1c478: Bluetooth: AD: Add support for AltBeacon |
Wireshark code review |
|
| 05:23 |
[Wireshark-commits] master 1ec2a69: Bluetooth: EIR/AD: Add support for LE Features and Channel Map |
Wireshark code review |
|
| 05:29 |
[Wireshark-commits] master 6e761f0: Add dissection of Bluetooth 5.0 AE related HCI commands |
Wireshark code review |
|
| 06:16 |
[Wireshark-commits] master 02190e7: .mailmap: Update (of January and February ) |
Wireshark code review |
|
| 06:24 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 06:49 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 14:04 |
[Wireshark-commits] master 96c756c: ssl-utils: fix false warning about empty SNI |
Wireshark code review |
|
| 14:46 |
[Wireshark-commits] master a2ce684: prefs: free memory on cleanup. |
Wireshark code review |
|
| 15:29 |
[Wireshark-commits] master c31b8da: stats_tree: add cleanup function. |
Wireshark code review |
|
| 16:34 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 17:24 |
[Wireshark-commits] master 2a4a6f6: Ubuntu 14.04 complains about unititialized variable proto_name_length |
Wireshark code review |
|
| 17:42 |
[Wireshark-commits] master 829b681: Update symbols |
Wireshark code review |
|
| 17:56 |
[Wireshark-commits] master 6d08a0e: [H248 Annex C] hf variable imported from packet-sdp, c is uint16 not int |
Wireshark code review |
|
| 18:39 |
[Wireshark-commits] master f958dd5: TLS13: support Early Data and accept CLIENT_EARLY_TRAFFIC_SECRET |
Wireshark code review |
|
| 18:49 |
[Wireshark-commits] master cecf9f1: TLS13: update NewSessionTicket dissection |
Wireshark code review |
|
| 20:43 |
[Wireshark-commits] master 1185fba: ui: Write recent file when applying profile changes |
Wireshark code review |
|
| 20:44 |
[Wireshark-commits] master-2.2 6c39753: ui: Write recent file when applying profile changes |
Wireshark code review |
|
| 20:45 |
[Wireshark-commits] master-2.0 f22d155: ui: Write recent file when applying profile changes |
Wireshark code review |
|
| 20:52 |
[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.6 x86 |
buildbot-no-reply |
|
| 21:37 |
[Wireshark-commits] master 0e74fbb: Make sure pid_t is defined. |
Wireshark code review |
|
| 21:37 |
[Wireshark-commits] buildbot failure in Wireshark 2.0 on Ubuntu 16.04 x64 |
buildbot-no-reply |
|
| 21:38 |
[Wireshark-commits] master-2.2 2f0b212: Make sure pid_t is defined. |
Wireshark code review |
|
| 21:39 |
[Wireshark-commits] master-2.0 d296ba6: Make sure pid_t is defined. |
Wireshark code review |
|
| 21:52 |
[Wireshark-commits] master 3f0e6d5: ssl-utils: add vector length validation for Client Hello |
Wireshark code review |
|
| 22:10 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 22:53 |
[Wireshark-commits] master ddd8380: ldap (asn1): fix indent (use 2 spaces) |
Wireshark code review |
|
| 22:53 |
[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| February 08, 2017 |
|---|
| 00:19 |
[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 02:22 |
[Wireshark-commits] master b3068a0: Fix a comment to match we-run-on-Windows-too reality. |
Wireshark code review |
|
| 09:08 |
[Wireshark-commits] master 64984b7: Qt: Add check for valid profile name |
Wireshark code review |
|
| 09:48 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 12:30 |
[Wireshark-commits] master 40fe50f: RSVDv2 support - 1st stage |
Wireshark code review |
|
| 12:45 |
[Wireshark-commits] master db5c8e1: wmem_list: add wmem_list_insert_sorted. |
Wireshark code review |
|
| 13:21 |
[Wireshark-commits] master 64a00dc: xml: replace g_strdup with wmem_strdup. |
Wireshark code review |
|
| 14:14 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 14:25 |
[Wireshark-commits] master 243c09f: Switch export objects to use wmem_tree_t instead of (sorted) GSList. |
Wireshark code review |
|
| 14:26 |
[Wireshark-commits] master 89dfa6b: Switch rtd and srt tables to use wmem_tree_t instead of (sorted) GSList. |
Wireshark code review |
|
| 14:27 |
[Wireshark-commits] master c5483f4: Switch follow (tables) to use wmem_tree_t instead of (sorted) GSList. |
Wireshark code review |
|
| 14:28 |
[Wireshark-commits] master 70381f7: Switch stat tap to use wmem_tree_t instead of (sorted) GSList. |
Wireshark code review |
|
| 14:50 |
[Wireshark-commits] master bfe0716: sharkd: make the way it returns more similar to other apps. |
Wireshark code review |
|
| 15:37 |
[Wireshark-commits] master 523c09f: addr_resolv: remove leak. |
Wireshark code review |
|
| 16:50 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 17:11 |
[Wireshark-commits] master 19ba947: dof: add shutdown routine. |
Wireshark code review |
|
| 20:55 |
[Wireshark-commits] master 2e0ea97: tap: destroy list on cleanup. |
Wireshark code review |
|
| 20:56 |
[Wireshark-commits] master edf5ae3: proto: destroy list on cleanup. |
Wireshark code review |
|
| 22:32 |
[Wireshark-commits] master b28b073: editcap: handle too short frames in frame comparison |
Wireshark code review |
|
| 23:13 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| February 09, 2017 |
|---|
| 00:20 |
[Wireshark-commits] master 9e2366a: Don't duplicate memory for key values when passing into wmem_tree_insert_string. |
Wireshark code review |
|
| 11:32 |
[Wireshark-commits] master 520a1b2: Make the capture file's interface description filterable |
Wireshark code review |
|
| 12:31 |
[Wireshark-commits] master-2.2 7769100: editcap: handle too short frames in frame comparison |
Wireshark code review |
|
| 12:39 |
[Wireshark-commits] buildbot failure in Wireshark 2.2 on Ubuntu 16.04 x64 |
buildbot-no-reply |
|
| 13:43 |
[Wireshark-commits] master-2.2 6df3ddc: Add wtap_init to dftest. |
Wireshark code review |
|
| 13:45 |
[Wireshark-commits] master 80e8f7d: Add wtap_init to dftest. |
Wireshark code review |
|
| 14:12 |
[Wireshark-commits] master-2.0 ef97919: editcap: handle too short frames in frame comparison |
Wireshark code review |
|
| 14:27 |
[Wireshark-commits] buildbot failure in Wireshark 2.0 on Ubuntu 16.04 x64 |
buildbot-no-reply |
|
| 16:17 |
[Wireshark-commits] master d03b6c0: dissectors: update list of controls in CTDB dissector. |
Wireshark code review |
|
| 18:13 |
[Wireshark-commits] master f6d9f7f: dof: free more memory on shutdown. |
Wireshark code review |
|
| 22:03 |
[Wireshark-commits] master cd38552: Add wmem_tree_remove32 |
Wireshark code review |
|
| 22:04 |
[Wireshark-commits] master e3128d9: Add wmem_map_steal |
Wireshark code review |
|
| 22:05 |
[Wireshark-commits] master f8b69fb: Add wmem_map_get_keys. |
Wireshark code review |
|
| February 10, 2017 |
|---|
| 03:43 |
[Wireshark-commits] master e0fafa5: Convert conversation data_list from GSList to wmem_tree. |
Wireshark code review |
|
| 03:46 |
[Wireshark-commits] master b18245a: mswsp: Numerous bugfixes |
Wireshark code review |
|
| 03:47 |
[Wireshark-commits] master 5c7cc28: mswsp: Align parse_CAggregSpec function with MS-WSP specification. |
Wireshark code review |
|
| 04:26 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 06:51 |
[Wireshark-commits] master-2.2 462ca74: mswsp: Numerous bugfixes |
Wireshark code review |
|
| 06:53 |
[Wireshark-commits] master-2.0 c68da8a: mswsp: Numerous bugfixes |
Wireshark code review |
|
| 07:29 |
[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86 |
buildbot-no-reply |
|
| 08:02 |
[Wireshark-commits] master-2.2 293dbe7: simple_dialog(.h): fix parameter 'Type' not found in the function declaration [-Wdocumentation] |
Wireshark code review |
|
| 10:20 |
[Wireshark-commits] master 424fef1: response_time_delay_dialog (Qt): Fix warning: parameter 'user_data/data' not found in the function declaration [-Wdocumentation] |
Wireshark code review |
|
| 10:21 |
[Wireshark-commits] master-2.0 eb275cf: rtp_player(.h): fix empty paragraph passed to '@param' command [-Wdocumentation] |
Wireshark code review |
|
| 10:22 |
[Wireshark-commits] master 8bbf034: service_response_time_table (GTK) fix parameter 'data' not found in the function declaration [-Wdocumentation] |
Wireshark code review |
|
| 10:45 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 13:27 |
[Wireshark-commits] master b54c438: Convert conversation hash tables to use wmem. |
Wireshark code review |
|
| 13:31 |
[Wireshark-commits] master 59fc668: Clean columns on exit. |
Wireshark code review |
|
| 13:35 |
[Wireshark-commits] master 9ced31a: filter_list: add cleanup function and call it on exit. |
Wireshark code review |
|
| 15:34 |
[Wireshark-commits] master 0bf7ba3: wmem_list: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang |
Wireshark code review |
|
| 18:23 |
[Wireshark-commits] master-2.0 cffb183: Cast away some compiler warnings. |
Wireshark code review |
|
| 19:03 |
[Wireshark-commits] master-2.2 11c9010: Cast away some compiler warnings. |
Wireshark code review |
|
| 20:27 |
[Wireshark-commits] master d13da6c: diameter_3gpp: added decoding of TWAN-Identifier AVP |
Wireshark code review |
|
| 23:46 |
[Wireshark-commits] master efed7b5: ssl-utils: stylistic changes for ServerHello, HelloRetryRequest |
Wireshark code review |
|
| 23:47 |
[Wireshark-commits] master a77b690: TLS13: add length validation for SupportedVersions |
Wireshark code review |
|
| 23:54 |
[Wireshark-commits] master b295829: ssl-utils: update supported_groups extension |
Wireshark code review |
|
| 23:59 |
[Wireshark-commits] master 738f4b7: TLS13: add length validation for Pre-Shared Key Extension |
Wireshark code review |
|
| February 11, 2017 |
|---|
| 00:01 |
[Wireshark-commits] master 0e08518: TLS13: add length validation for Pre-Shared Key Exchange Modes |
Wireshark code review |
|
| 00:10 |
[Wireshark-commits] master 8136258: ssl-utils: add length validation to CertificateRequest |
Wireshark code review |
|
| 00:11 |
[Wireshark-commits] master b659c76: TLS13: fix length of Finished message |
Wireshark code review |
|
| 00:27 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 10:48 |
[Wireshark-commits] master 746bbe7: ssl-utils: add length validation for Certificate handshake message |
Wireshark code review |
|
| 11:29 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 13:23 |
[Wireshark-commits] master eb1a63f: TLS13: add Key Update dissection |
Wireshark code review |
|
| 13:24 |
[Wireshark-commits] master 6cc7a70: TLS13: handle Key Update for decryption |
Wireshark code review |
|
| 14:16 |
[Wireshark-commits] master a2b48ad: Fixing the MAC tvb creation in FP's tb dissection method |
Wireshark code review |
|
| 16:29 |
[Wireshark-commits] master-2.2 f3905cc: Fixing the MAC tvb creation in FP's tb dissection method |
Wireshark code review |
|
| 17:52 |
[Wireshark-commits] master-2.0 32c66f5: Fixing the MAC tvb creation in FP's tb dissection method |
Wireshark code review |
|
| 20:10 |
[Wireshark-commits] master b8ead95: tshark print_indent function |
Wireshark code review |
|
| February 12, 2017 |
|---|
| 08:39 |
[Wireshark-commits] master 4125aa1: Decode QCA sniffer PRISM extensions, and populate some wlan_radio fields. |
Wireshark code review |
|
| 09:05 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 09:34 |
[Wireshark-commits] master 386a286: signal() is defined on some UN*Xes; don't use it as a variable name. |
Wireshark code review |
|
| 09:47 |
[Wireshark-commits] master e2c92fa: White space/style cleanup and consistency. |
Wireshark code review |
|
| 09:53 |
[Wireshark-commits] master 6a37625: Add a comment about wired-to-little-endian fields. |
Wireshark code review |
|
| 10:04 |
[Wireshark-commits] master 6bbbc34: Fill in pseudo-header fields in order, and add the group ID for 11ac. |
Wireshark code review |
|
| 13:47 |
[Wireshark-commits] master 1e1ceeb: Put the definitions first |
Wireshark code review |
|
| 16:07 |
[Wireshark-commits] master-2.2 27a4476: Put the definitions first |
Wireshark code review |
|
| 16:13 |
[Wireshark-commits] master 6550b10: [Automatic update for 2017-02-12] |
Wireshark code review |
|
| 16:15 |
[Wireshark-commits] master fb3a7ca: [skinny] Fix ConnectionStatRes and DialedNumber Messages protocol version >20 |
Wireshark code review |
|
| 16:21 |
[Wireshark-commits] master-2.2 36c85f6: [Automatic update for 2017-02-12] |
Wireshark code review |
|
| 16:22 |
[Wireshark-commits] master ea0a7f2: [skinny]: Add struct/union guards to multi-part message handlers |
Wireshark code review |
|
| 16:30 |
[Wireshark-commits] master-2.0 f4f191d: [Automatic update for 2017-02-12] |
Wireshark code review |
|
| 17:01 |
[Wireshark-commits] master 6322f9c: uat: add missing parameter to documentation. |
Wireshark code review |
|
| 17:04 |
[Wireshark-commits] master dc3b772: tshark removed empty line in -T ek output |
Wireshark code review |
|
| 17:51 |
[Wireshark-commits] master 8bc29d1: sharkd: fix a memory leak on Windows introduced in gfe06aad |
Wireshark code review |
|
| 17:56 |
[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 18:16 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 19:00 |
[Wireshark-commits] master ad2eb83: Set the partial AID in the radio metadata structure. |
Wireshark code review |
|
| 19:10 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 23:18 |
[Wireshark-commits] master ece6e7c: Fix compilation without plugins. |
Wireshark code review |
|
| 23:59 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| February 13, 2017 |
|---|
| 03:31 |
[Wireshark-commits] master b009095: Fix a comment to reflect (and better explain) reality. |
Wireshark code review |
|
| 03:34 |
[Wireshark-commits] master 940c758: Further explanation in comments. |
Wireshark code review |
|
| 16:44 |
[Wireshark-commits] master 119bf86: tools: add suppressions to valgrind. |
Wireshark code review |
|
| 17:24 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 17:37 |
[Wireshark-commits] master b5610a0: [ISAKMP] Dissect 3GPP private error and status messages in NOTIFY. |
Wireshark code review |
|
| 18:36 |
[Wireshark-commits] master 6b84dde: Make Libgcrypt a mandatory dependency |
Wireshark code review |
|
| 19:23 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 22:03 |
[Wireshark-commits] master 993e098: Change Qt setup from 5.5.0 to 5.8.0 |
Wireshark code review |
|
| February 14, 2017 |
|---|
| 04:55 |
[Wireshark-commits] master ae0bdcc: [Diameter AVPs] Add 3GPP AVP 1664 to 1680 from TS 29.272 |
Wireshark code review |
|
| 05:37 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 10:23 |
[Wireshark-commits] master 7c0c580: wiretap: add cleanup routine. |
Wireshark code review |
|
| 10:46 |
[Wireshark-commits] master 4b423c5: gtp: changed display format of a FQDN from BYTES to STRING |
Wireshark code review |
|
| 13:26 |
[Wireshark-commits] master 415580b: tshark: free capture file filename on exit. |
Wireshark code review |
|
| 13:40 |
[Wireshark-commits] master 319de13: Handle NSAP IPv4 addresses in NBAP's TransportLayerAddress field which aren't padded to 20 bytes (= max NSAP address length, expected by NSAP dissector). |
Wireshark code review |
|
| 13:48 |
[Wireshark-commits] master-2.2 90095c7: Do not set Qt Window focus when highlighting rows |
Wireshark code review |
|
| 14:32 |
[Wireshark-commits] master 0ed1065: rawshark: add initializer. |
Wireshark code review |
|
| 15:37 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 17:24 |
[Wireshark-commits] master bc29b8c: androiddump: fix compilation with ANDROIDDUMP_USE_LIBPCAP define |
Wireshark code review |
|
| 18:03 |
[Wireshark-commits] master fe78e13: BT LE LL: fix invalid memory access reported by valgrind |
Wireshark code review |
|
| 18:16 |
[Wireshark-commits] master c01cdd4: Qt: Reset Default profile support |
Wireshark code review |
|
| 19:07 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 20:02 |
[Wireshark-commits] master 6f18fed: wiretap: fix wtap_opttypes_cleanup() function |
Wireshark code review |
|
| February 15, 2017 |
|---|
| 07:06 |
[Wireshark-commits] master 78ce70e: Qt: Indicate profile created from system provided |
Wireshark code review |
|
| 07:07 |
[Wireshark-commits] master-2.2 dcf5c32: Qt: Indicate profile created from system provided |
Wireshark code review |
|
| 07:47 |
[Wireshark-commits] wireshark-win32-libs rev 517: / /trunk/packages/: c-ares-1.12.0-1-win32ws.zip gnutls-3.4.11-1.36-win32ws.zip libgcrypt-1.7.6-win32ws.zip libssh-0.7.3-1-win32ws.zip /trunk/: README.txt ... |
pascal |
|
| 08:05 |
[Wireshark-commits] wireshark-win64-libs rev 470: / /trunk/packages/: c-ares-1.12.0-1-win64ws.zip gnutls-3.4.11-1.35-win64ws.zip libgcrypt-1.7.6-win64ws.zip libssh-0.7.3-1-win64ws.zip /trunk/: README.txt ... |
pascal |
|
| 10:07 |
[Wireshark-commits] master efcb5c0: Display 4 octets SDVL with 3 bits in ROHC |
Wireshark code review |
|
| 12:20 |
[Wireshark-commits] master bb1450b: ssl, dtls: fix wrong expert info for overly large records |
Wireshark code review |
|
| 12:25 |
[Wireshark-commits] master e207506: TLS13: dissect NewSessionTicket and CertificateRequest extensions |
Wireshark code review |
|
| 12:27 |
[Wireshark-commits] master 3e7f32e: ssl-utils: sort extensions cases |
Wireshark code review |
|
| 12:28 |
[Wireshark-commits] master a691315: TLS13: handle message-specific TLS extensions |
Wireshark code review |
|
| 12:29 |
[Wireshark-commits] master-2.2 54517d2: Display 4 octets SDVL with 3 bits in ROHC |
Wireshark code review |
|
| 12:30 |
[Wireshark-commits] master-2.0 a825731: Display 4 octets SDVL with 3 bits in ROHC |
Wireshark code review |
|
| 12:51 |
[Wireshark-commits] wireshark-win64-libs rev 471: /tags/2017-02-15/ |
pascal |
|
| 12:53 |
[Wireshark-commits] wireshark-win32-libs rev 518: /tags/2017-02-15/ /tags/2017-02-15/: README.txt README.txt /tags/2017-02-15/packages/: c-ares-1.12.0-1-win32ws.zip gnutls-3.4.11-1.36-win32ws.zip ... |
pascal |
|
| 17:33 |
[Wireshark-commits] master 0b8a12f: Windows: update GnuTLS to 3.4.11 and Libgcrypt to 1.7.6 |
Wireshark code review |
|
| 20:38 |
[Wireshark-commits] master 0f59480: ifdef g_list_free_full it requires glib 2.28 |
Wireshark code review |
|
| 20:59 |
[Wireshark-commits] master 64f8364: Cleanup runlex.sh to use builtin POSIX functions instead of sed |
Wireshark code review |
|
| February 16, 2017 |
|---|
| 00:47 |
[Wireshark-commits] master 724dc1c: "NULL" is not what you use for a null pointer. |
Wireshark code review |
|
| 00:49 |
[Wireshark-commits] master-2.2 a484eb9: "NULL" is not what you use for a null pointer. |
Wireshark code review |
|
| 00:50 |
[Wireshark-commits] master-2.0 768b279: "NULL" is not what you use for a null pointer. |
Wireshark code review |
|
| 04:58 |
[Wireshark-commits] master cd1d90e: ROHC: Basic support for RTP extension 3 |
Wireshark code review |
|
| 05:01 |
[Wireshark-commits] master e6c51e7: Couchbase: Add support for XATTRs |
Wireshark code review |
|
| 05:02 |
[Wireshark-commits] master 9a22102: [skinny]: Added conversation and request_response handling |
Wireshark code review |
|
| 05:05 |
[Wireshark-commits] master 23d3a30: ssl-utils: refactor DigitallySigned |
Wireshark code review |
|
| 05:08 |
[Wireshark-commits] master c529e91: TLS: add Signed Certificate Timestamp support (RFC 6962) |
Wireshark code review |
|
| 05:09 |
[Wireshark-commits] master d718b1d: Qt: Preserve pane sizes when changing profile |
Wireshark code review |
|
| 05:12 |
[Wireshark-commits] master 989b9d5: ssl: fix misdetection of HelloRequest handshake message |
Wireshark code review |
|
| 05:14 |
[Wireshark-commits] master a98eb3c: Qt: Auto detect pane size when configured zero |
Wireshark code review |
|
| 05:15 |
[Wireshark-commits] master 34b9836: Qt: Reset pane sizes when layout type changed |
Wireshark code review |
|
| 05:43 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 06:30 |
[Wireshark-commits] master-2.2 8cd41a0: Qt: Preserve pane sizes when changing profile |
Wireshark code review |
|
| 06:32 |
[Wireshark-commits] master-2.2 8a4d259: Qt: Auto detect pane size when configured zero |
Wireshark code review |
|
| 06:43 |
[Wireshark-commits] master 1077e9a: Squelch a compiler warning. |
Wireshark code review |
|
| 06:58 |
[Wireshark-commits] master-2.2 28c0536: Qt: Reset pane sizes when layout type changed |
Wireshark code review |
|
| 07:13 |
[Wireshark-commits] buildbot failure in Wireshark 2.2 on OSX 10.7 x64 |
buildbot-no-reply |
|
| 07:14 |
[Wireshark-commits] buildbot failure in Wireshark 2.2 on Ubuntu 16.04 x64 |
buildbot-no-reply |
|
| 07:28 |
[Wireshark-commits] master 54c0a6d: Cast away some compiler warnings. |
Wireshark code review |
|
| 07:34 |
[Wireshark-commits] master-2.2 5609829: Qt: Use correct wsApp signal for RecentFilesRead |
Wireshark code review |
|
| 07:54 |
[Wireshark-commits] master bc2b135: Add follow "types" by protocol short name, not filter name |
Wireshark code review |
|
| 08:02 |
[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 08:16 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 08:20 |
[Wireshark-commits] master c7042be: Report an error for too-short packets. |
Wireshark code review |
|
| 08:21 |
[Wireshark-commits] master-2.2 83aa52d: Report an error for too-short packets. |
Wireshark code review |
|
| 08:22 |
[Wireshark-commits] master-2.0 38b428a: Report an error for too-short packets. |
Wireshark code review |
|
| 08:32 |
[Wireshark-commits] master 6efc0f4: Updated URL for STANAG 4607 documentation. |
Wireshark code review |
|
| 08:33 |
[Wireshark-commits] master-2.2 26c3ebc: Updated URL for STANAG 4607 documentation. |
Wireshark code review |
|
| 08:34 |
[Wireshark-commits] master-2.0 a1f72e1: Updated URL for STANAG 4607 documentation. |
Wireshark code review |
|
| 09:05 |
[Wireshark-commits] buildbot failure in Wireshark 2.2 on Ubuntu 16.04 x64 |
buildbot-no-reply |
|
| 09:53 |
[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86 |
buildbot-no-reply |
|
| 12:59 |
[Wireshark-commits] master e2cef4c: Qt: Improved pane size auto detect |
Wireshark code review |
|
| 13:00 |
[Wireshark-commits] master-2.2 7076f9e: Qt: Improved pane size auto detect |
Wireshark code review |
|
| 13:37 |
[Wireshark-commits] master ba643d6: [GSM RLCMAC] Added parsing of EC-EGPRS DL and UL data messages. |
Wireshark code review |
|
| 13:50 |
[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows 8.1 x86 |
buildbot-no-reply |
|
| 14:21 |
[Wireshark-commits] master 656da8a: ifdef g_list_free_full it requires glib 2.28 |
Wireshark code review |
|
| 15:00 |
[Wireshark-commits] master d33f7b9: [GSM RLCMAC] Use rtlli_vals |
Wireshark code review |
|
| 15:17 |
[Wireshark-commits] master a467f63: packet-nvme-rdma: Present keep alive timeout in decimal. |
Wireshark code review |
|
| 15:44 |
[Wireshark-commits] master 815916b: [GTPv2] Add dissection of Node Identifier. |
Wireshark code review |
|
| 16:59 |
[Wireshark-commits] master a5a8fce: Qt: Warn the user about DBAR 1.8 on Windows. |
Wireshark code review |
|
| 17:32 |
[Wireshark-commits] master 7e9b7b5: opcua: display abort messages correctly |
Wireshark code review |
|
| 20:53 |
[Wireshark-commits] master 384c266: Qt: Preserve pane sizes when layout content changed |
Wireshark code review |
|
| 20:55 |
[Wireshark-commits] master 14e1912: Qt: Disable pane menu items if not used in layout |
Wireshark code review |
|
| 20:58 |
[Wireshark-commits] master-2.2 419c497: Qt: Preserve pane sizes when layout content changed |
Wireshark code review |
|
| 21:00 |
[Wireshark-commits] master-2.2 c3d895f: Qt: Disable pane menu items if not used in layout |
Wireshark code review |
|
| 21:04 |
[Wireshark-commits] master 16c3ecb: g_slist_free_full requires glib 2.28 |
Wireshark code review |
|
| February 17, 2017 |
|---|
| 04:55 |
[Wireshark-commits] master 48eff6a: Bluetooth: AD: Add dissector for Apple iBeacon |
Wireshark code review |
|
| 07:36 |
[Wireshark-commits] master-2.2 b88bb55: Qt: Warn the user about DBAR 1.8 on Windows. |
Wireshark code review |
|
| 17:20 |
[Wireshark-commits] master 560a6c3: Rawshark: Try to avoid a VC runtime crash. |
Wireshark code review |
|
| 18:24 |
[Wireshark-commits] master-2.0 b29a4f0: Qt: Warn the user about DBAR 1.8 on Windows. |
Wireshark code review |
|
| 20:27 |
[Wireshark-commits] master b59c87f: CMake: Move the search for libgcc_s to GLib. |
Wireshark code review |
|
| 21:55 |
[Wireshark-commits] master 9e1232e: Convert IEEE802.11 tagged fields into a dissector table |
Wireshark code review |
|
| 21:56 |
[Wireshark-commits] master 52637ad: Dissector: Add IEEE802.11 mesh awake window dissector |
Wireshark code review |
|
| 22:36 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 22:36 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64 |
buildbot-no-reply |
|
| 22:55 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| February 18, 2017 |
|---|
| 01:18 |
[Wireshark-commits] master 67d8830: wiretap: add open_routines cleanup function. |
Wireshark code review |
|
| 02:00 |
[Wireshark-commits] master 46ae4ac: RSVD TUNNEL_SCSI bugfix: SCSI payload is not dissected for request packets |
Wireshark code review |
|
| 02:39 |
[Wireshark-commits] master 2c3dda5: SMB2 ioctl FSCTL_STORAGE_QOS_CONTROL dissector |
Wireshark code review |
|
| 03:10 |
[Wireshark-commits] master 5d3d96c: transum: Add protections against NULL trees. |
Wireshark code review |
|
| 04:56 |
[Wireshark-commits] master 7d83068: user_encap: Don't allocate duplicate strings for user_encap2 |
Wireshark code review |
|
| 07:09 |
[Wireshark-commits] master 7ccc551: Modbus - Add ability to filter by holding/input register number OR value |
Wireshark code review |
|
| 07:11 |
[Wireshark-commits] master-2.0 d0a0516: Rawshark: Try to avoid a VC runtime crash. |
Wireshark code review |
|
| 07:12 |
[Wireshark-commits] master-2.2 d185415: Rawshark: Try to avoid a VC runtime crash. |
Wireshark code review |
|
| 07:14 |
[Wireshark-commits] master 35cf66d: file-pcapng: Add support for inspecting Apple's PKTAP enhanced pcapng files |
Wireshark code review |
|
| 07:15 |
[Wireshark-commits] master 3d02987: roofnet: decode framed ethernet frames. |
Wireshark code review |
|
| 08:43 |
[Wireshark-commits] master 19b97fb: Why you only get 16 bytes of process name. |
Wireshark code review |
|
| 09:09 |
[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 13:46 |
[Wireshark-commits] master 6d79055: wsutil: remove leaks from filesystem and plugins code. |
Wireshark code review |
|
| 14:12 |
[Wireshark-commits] master f792625: epan/wsutil: free memory on exit. |
Wireshark code review |
|
| 14:14 |
[Wireshark-commits] master 64d0133: plugins: free list on cleanup. |
Wireshark code review |
|
| 14:22 |
[Wireshark-commits] master fcc9cf2: proto: ensure that length is set for proto_tree_add_item_new_ret_length |
Wireshark code review |
|
| 17:33 |
[Wireshark-commits] master 279dc61: roofnet: fix indent (add some missing space) |
Wireshark code review |
|
| 17:34 |
[Wireshark-commits] master 45a216e: roofnet: always declare variable on the top |
Wireshark code review |
|
| 17:35 |
[Wireshark-commits] master 8c758f0: roofnet: display always reserved field |
Wireshark code review |
|
| 22:36 |
[Wireshark-commits] master 0a4273f: Only cleanup open_routines if not NULL |
Wireshark code review |
|
| 23:16 |
[Wireshark-commits] master f7724c3: file-pcapng: Undo some unnecessary changes. |
Wireshark code review |
|
| 23:27 |
[Wireshark-commits] master 7e70311: Fix ieee80211_tag_ssid |
Wireshark code review |
|
| February 19, 2017 |
|---|
| 01:28 |
[Wireshark-commits] master 897c750: Clean up some memory leaks in wsutil/filesystem.c |
Wireshark code review |
|
| 02:31 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 13:26 |
[Wireshark-commits] master e2951a2: stat_tap_ui: remove leaks. |
Wireshark code review |
|
| 16:13 |
[Wireshark-commits] master ef20188: [Automatic update for 2017-02-19] |
Wireshark code review |
|
| 16:16 |
[Wireshark-commits] master dc173f9: tap: use g_new0() instead of g_new() and memset() |
Wireshark code review |
|
| 16:21 |
[Wireshark-commits] master-2.2 fdc7845: [Automatic update for 2017-02-19] |
Wireshark code review |
|
| 16:30 |
[Wireshark-commits] master-2.0 bc281f2: [Automatic update for 2017-02-19] |
Wireshark code review |
|
| 21:08 |
[Wireshark-commits] master 9b00828: packet-tns.c: Add Sesskey, Auth (SQLNET_RETURN_OPI_PARAM) |
Wireshark code review |
|
| 21:20 |
[Wireshark-commits] master 9ce32f9: BGP: add Deprecated BGP Path Attribute (RFC 8093) |
Wireshark code review |
|
| 21:21 |
[Wireshark-commits] master 351e892: BGP: Update some draft to final RFC |
Wireshark code review |
|
| 21:23 |
[Wireshark-commits] master 29733ad: DNS: Don't display DNSSEC Protocol and Algo in flag tree |
Wireshark code review |
|
| 22:46 |
[Wireshark-commits] master d1b943d: stat_tap_ui: skip duplicate keys. |
Wireshark code review |
|
| February 20, 2017 |
|---|
| 05:54 |
[Wireshark-commits] master b3f435e: Qt: Add "Reset Layout" |
Wireshark code review |
|
| 05:55 |
[Wireshark-commits] master 6c65486: Qt: Mystery pixel issue is solved |
Wireshark code review |
|
| 12:56 |
[Wireshark-commits] master e2e4415: Add some glib functions not available in older glibs |
Wireshark code review |
|
| 13:20 |
[Wireshark-commits] master 1089211: SNMP: duplicate dynamic members of snmp_ue_assoc_t structure in localize_ue() |
Wireshark code review |
|
| 13:31 |
[Wireshark-commits] master 52ce1b0: SNMP: fix insertion of first entry in SNMP Users UAT |
Wireshark code review |
|
| 14:53 |
[Wireshark-commits] master 94559de: [Diameter] Add 3GPP AVPs |
Wireshark code review |
|
| 16:52 |
[Wireshark-commits] master 6e8066c: stats_tree: fix no previous prototype for ‘stats_tree_cfg_free’ [-Wmissing-prototypes] |
Wireshark code review |
|
| 16:54 |
[Wireshark-commits] master-2.2 f693761: SNMP: duplicate dynamic members of snmp_ue_assoc_t structure in localize_ue() |
Wireshark code review |
|
| 16:55 |
[Wireshark-commits] master d84577f: Yell at the user less. |
Wireshark code review |
|
| 18:30 |
[Wireshark-commits] master 9f47916: print(.h): fix commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions] |
Wireshark code review |
|
| 18:31 |
[Wireshark-commits] master dfb05b9: wtap_opttypes(.h): fix commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions] |
Wireshark code review |
|
| 18:32 |
[Wireshark-commits] master-2.0 c1da9b7: SNMP: duplicate dynamic members of snmp_ue_assoc_t structure in localize_ue() |
Wireshark code review |
|
| 18:33 |
[Wireshark-commits] master-2.2 f253123: Qt: Mystery pixel issue is solved |
Wireshark code review |
|
| 20:14 |
[Wireshark-commits] master 05cda40: [BSSGP] Dissect new Extended Feature Bitmap fields. |
Wireshark code review |
|
| 20:16 |
[Wireshark-commits] master 3aa8887: [GTP] Make flag fields boolean. |
Wireshark code review |
|
| 20:35 |
[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 20:51 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 20:56 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64 |
buildbot-no-reply |
|
| 21:27 |
[Wireshark-commits] master 124807e: Fix a typo and a copy-and-pasteo. |
Wireshark code review |
|
| 23:07 |
[Wireshark-commits] master b82f7c5: Calling g_hash_table_size with a NULL argument causes a GLib-CRITICAL. |
Wireshark code review |
|
| 23:13 |
[Wireshark-commits] master e18ad46: Don't use identical log messages for non-identical error cases. |
Wireshark code review |
|
| February 21, 2017 |
|---|
| 02:32 |
[Wireshark-commits] master 72e2c3a: Have a routine to iterate over the remote host list. |
Wireshark code review |
|
| 02:47 |
[Wireshark-commits] master 2798f7c: Have all the remote host list routines' names begin with recent_. |
Wireshark code review |
|
| 03:06 |
[Wireshark-commits] master 987244e: New/updated reference URLs. |
Wireshark code review |
|
| 03:25 |
[Wireshark-commits] master c46f8b6: Get rid of unused variable. |
Wireshark code review |
|
| 04:42 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 05:39 |
[Wireshark-commits] master 86cc732: tns(.h): Remove unneeded h file |
Wireshark code review |
|
| 05:40 |
[Wireshark-commits] master 66e4541: cmake: SET_FEATURE_INFO don't need to add www: for URL |
Wireshark code review |
|
| 05:41 |
[Wireshark-commits] master fdecfa6: cmake: Add some missing SET_FEATURE_INFO |
Wireshark code review |
|
| 05:45 |
[Wireshark-commits] master ed8b549: Couchbase: Add SSL support |
Wireshark code review |
|
| 05:46 |
[Wireshark-commits] master c5ce5a8: couchbase: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang |
Wireshark code review |
|
| 05:48 |
[Wireshark-commits] master c258989: DNS: Add Edwards-Curve Digital Security Algorithm (EdDSA) for DNSSEC (RFC 8080) |
Wireshark code review |
|
| 05:49 |
[Wireshark-commits] master-2.0 523e132: opcua: display abort messages correctly |
Wireshark code review |
|
| 05:50 |
[Wireshark-commits] master-2.2 e7176e9: opcua: display abort messages correctly |
Wireshark code review |
|
| 11:49 |
[Wireshark-commits] master 4b722f2: [GSM RLCMAC] Fix column info. |
Wireshark code review |
|
| 14:21 |
[Wireshark-commits] master 6814cf4: Qt: Handle cancel in import coloring rules |
Wireshark code review |
|
| 14:23 |
[Wireshark-commits] master-2.2 98004d7: Qt: Handle cancel in import coloring rules |
Wireshark code review |
|
| 14:24 |
[Wireshark-commits] master f04e770: [GSM A BSSMAP] Correct a cause value according to TS 48.008 V13.2.0 |
Wireshark code review |
|
| 19:04 |
[Wireshark-commits] master 012a179: Fix a double free. |
Wireshark code review |
|
| 20:04 |
[Wireshark-commits] master b9851c7: Snort: use GRegex to find pcre matches |
Wireshark code review |
|
| February 22, 2017 |
|---|
| 00:34 |
[Wireshark-commits] master 50dff6e: Make sure we zero out the newly allocated list, otherwise g_list append may dereference ->next containing an arbitrary value. |
Wireshark code review |
|
| 01:14 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 01:43 |
[Wireshark-commits] master 0327078: Only do save_errno = errno and errno = save_errno around g_free(); |
Wireshark code review |
|
| 03:38 |
[Wireshark-commits] master-2.2 a9396c6: Calling g_hash_table_size with a NULL argument causes a GLib-CRITICAL. |
Wireshark code review |
|
| 03:39 |
[Wireshark-commits] master-2.0 586769e: Calling g_hash_table_size with a NULL argument causes a GLib-CRITICAL. |
Wireshark code review |
|
| 03:40 |
[Wireshark-commits] master-2.2 2170755: Don't use identical log messages for non-identical error cases. |
Wireshark code review |
|
| 03:42 |
[Wireshark-commits] master-2.0 3f8b0af: Don't use identical log messages for non-identical error cases. |
Wireshark code review |
|
| 03:43 |
[Wireshark-commits] master-2.2 e563bd1: Make sure we zero out the newly allocated list, otherwise g_list append may dereference ->next containing an arbitrary value. |
Wireshark code review |
|
| 04:10 |
[Wireshark-commits] master c1ab23d: Clean up the get_if_capabilities_ routines a bit. |
Wireshark code review |
|
| 04:11 |
[Wireshark-commits] master-2.2 63da580: Clean up the get_if_capabilities_ routines a bit. |
Wireshark code review |
|
| 04:18 |
[Wireshark-commits] buildbot failure in Wireshark 2.0 on Ubuntu 16.04 x64 |
buildbot-no-reply |
|
| 04:21 |
[Wireshark-commits] master-2.0 f1c505d: Make sure caps->data_link_types is initialized. |
Wireshark code review |
|
| 04:38 |
[Wireshark-commits] master 882fa72: L&G 8979 - Fix 'flags' display and RTU->master echoed responses from SBO commands |
Wireshark code review |
|
| 05:19 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 05:37 |
[Wireshark-commits] master e88d445: Faking different U-RNTIs for different CCCH streams. |
Wireshark code review |
|
| 05:38 |
[Wireshark-commits] master a4d7793: Qt: Avoid flicker in filter expressions toolbar |
Wireshark code review |
|
| 05:40 |
[Wireshark-commits] master 73ac697: [skinny]: Fix tvb struct size guard value |
Wireshark code review |
|
| 06:10 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 06:14 |
[Wireshark-commits] buildbot failure in Wireshark 2.0 on Windows 8.1 x86 |
buildbot-no-reply |
|
| 07:59 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 13:41 |
[Wireshark-commits] master 6dce310: extcap: Reduce number of scans and storage |
Wireshark code review |
|
| 13:59 |
[Wireshark-commits] master f977ddd: Qt: free memory used by rtd_tables. |
Wireshark code review |
|
| 14:00 |
[Wireshark-commits] master e47f9fb: Qt: call cleanup from destructor in WiresharkApplication. |
Wireshark code review |
|
| 14:01 |
[Wireshark-commits] master 23c8335: reordercap: free memory on exit |
Wireshark code review |
|
| 14:02 |
[Wireshark-commits] master 955cf0b: editcap: use single exit point. |
Wireshark code review |
|
| 14:21 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 15:21 |
[Wireshark-commits] master 68f94bd: mergecap: free memory on shutdown. |
Wireshark code review |
|
| 20:50 |
[Wireshark-commits] master 936a4c1: GPRS-NS: display nsip.cause and nsip.pdu_type as BASE_HEX |
Wireshark code review |
|
| 21:29 |
[Wireshark-commits] master-2.2 e55d4b0: GPRS-NS: display nsip.cause and nsip.pdu_type as BASE_HEX |
Wireshark code review |
|
| 21:30 |
[Wireshark-commits] master-2.0 f316a3f: GPRS-NS: display nsip.cause and nsip.pdu_type as BASE_HEX |
Wireshark code review |
|
| 21:34 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 21:54 |
[Wireshark-commits] master 785a0d8: g_malloc -> g_malloc0 where not all struct elements are initialized or when combined with memset. |
Wireshark code review |
|
| 22:34 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 23:21 |
[Wireshark-commits] master 67f4673: geoip_db: replace g_free with free. |
Wireshark code review |
|
| 23:47 |
[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| February 23, 2017 |
|---|
| 03:35 |
[Wireshark-commits] master 2651232: Make IP options into a dissector table. |
Wireshark code review |
|
| 03:37 |
[Wireshark-commits] master 453cccd: USB COM: highlight the bytes of the communications descriptor |
Wireshark code review |
|
| 04:18 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 06:58 |
[Wireshark-commits] master-2.2 c043109: Qt: Avoid flicker in filter expressions toolbar |
Wireshark code review |
|
| February 24, 2017 |
|---|
| 02:13 |
[Wireshark-commits] master 99929f7: sharkd: fix redundant redeclaration of ‘cfile’ [-Wredundant-decls] |
Wireshark code review |
|
| 02:15 |
[Wireshark-commits] master eef1555: Fix sharkd compilation on some <glibc-2.16 or <gcc-4.8 |
Wireshark code review |
|
| 04:42 |
[Wireshark-commits] master d347a60: Make MIPv6 options into a dissector table. |
Wireshark code review |
|
| 04:43 |
[Wireshark-commits] master bd9afdd: Reduce number of fwrite when writing pcap-ng EPB. |
Wireshark code review |
|
| 08:13 |
[Wireshark-commits] master 321386e: PluginIF: AdditionalToolbar |
Wireshark code review |
|
| 09:05 |
[Wireshark-commits] master 3697192: pluginif: Add documentation for toolbar interface |
Wireshark code review |
|
| 09:12 |
[Wireshark-commits] master beea673: Qt: Code cleanup |
Wireshark code review |
|
| 09:59 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 11:07 |
[Wireshark-commits] master 8e6b5c1: Developers Guide typo |
Wireshark code review |
|
| 13:50 |
[Wireshark-commits] master f22c713: tools: add options validation. |
Wireshark code review |
|
| 13:58 |
[Wireshark-commits] master 147d0c2: androiddump: Use nonblocking connect |
Wireshark code review |
|
| 14:30 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 15:40 |
[Wireshark-commits] master 43487d8: udpdump: fix help. |
Wireshark code review |
|
| 15:44 |
[Wireshark-commits] master e1282f2: dtd: free memory on shutdown. |
Wireshark code review |
|
| 16:02 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 19:22 |
[Wireshark-commits] master 42cf565: dtd: fix build due to -Wtypedef-redefinition |
Wireshark code review |
|
| 20:04 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| February 25, 2017 |
|---|
| 06:33 |
[Wireshark-commits] master faaff7d: Replace "n/a" with an em dash. |
Wireshark code review |
|
| 11:06 |
[Wireshark-commits] master 762bf10: Configuration dump for webshark. |
Wireshark code review |
|
| 11:46 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 13:36 |
[Wireshark-commits] master 924e6d2: packet-fw1.c: header should be packet scoped, not epan scoped |
Wireshark code review |
|
| 13:37 |
[Wireshark-commits] master 7227728: Convert a few more dissectors to use wmem_hash instead of GHashtable. |
Wireshark code review |
|
| 13:38 |
[Wireshark-commits] master dfc26ac: Fix compilation without plugins: |
Wireshark code review |
|
| 14:16 |
[Wireshark-commits] master d00dae7: RADIUS: update nomadix dictionary (from FreeRADIUS) |
Wireshark code review |
|
| 15:44 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 19:11 |
[Wireshark-commits] master cd7d159: json2pcap support added |
Wireshark code review |
|
| 23:09 |
[Wireshark-commits] master d464d9c: Revert "Qt: call cleanup from destructor in WiresharkApplication." |
Wireshark code review |
|
| 23:50 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| February 26, 2017 |
|---|
| 01:55 |
[Wireshark-commits] master b912070: RADIUS: add cnergee dictionary (from FreeRADIUS) |
Wireshark code review |
|
| 02:03 |
[Wireshark-commits] master 3cc899a: smb2: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang |
Wireshark code review |
|
| 03:15 |
[Wireshark-commits] master 043ed1f: androiddump: Set connect socket to non-blocking on Windows |
Wireshark code review |
|
| 04:04 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 09:21 |
[Wireshark-commits] master 9782d55: plugin_if(.h): fix commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions] |
Wireshark code review |
|
| 09:23 |
[Wireshark-commits] master f3d52cb: Bugfix for extcap fileselect functionality, start button in extcap options dialog wouldn't get enabled if the user had selected a file (and mustexist=true wasn't specified). |
Wireshark code review |
|
| 13:13 |
[Wireshark-commits] master 2cfac2c: pluginif: Adapt code for Qt4.8 |
Wireshark code review |
|
| 15:10 |
[Wireshark-commits] master eff4173: preferences_dialog (Qt): fix commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions] |
Wireshark code review |
|
| 15:11 |
[Wireshark-commits] master 8202dd3: plugin_if: fix no previous prototype for ‘ext_toolbar_find_item’ [-Wmissing-prototypes] |
Wireshark code review |
|
| 15:12 |
[Wireshark-commits] master b3539fd: apply_line_edit(.h): fix extra ';' inside a class [-Wextra-semi] (clang) / extra ‘;’ [-Wpedantic] (gcc) |
Wireshark code review |
|
| 16:12 |
[Wireshark-commits] master d8e16b7: [Automatic update for 2017-02-26] |
Wireshark code review |
|
| 16:19 |
[Wireshark-commits] master-2.2 4f9839f: [Automatic update for 2017-02-26] |
Wireshark code review |
|
| 16:28 |
[Wireshark-commits] master-2.0 5a3b90d: [Automatic update for 2017-02-26] |
Wireshark code review |
|
| 17:50 |
[Wireshark-commits] master 74f4664: Remove executable bit, from not executable files. |
Wireshark code review |
|
| 17:52 |
[Wireshark-commits] master dcfc288: Qt: Enable/disable Capture Interfaces buttons consistently. |
Wireshark code review |
|
| 18:01 |
[Wireshark-commits] master 2de30dd: wsutil: fix bugs in plugins_cleanup(). |
Wireshark code review |
|
| 18:42 |
[Wireshark-commits] master 53fb7e4: capinfos: use single exit point. |
Wireshark code review |
|
| 19:41 |
[Wireshark-commits] master 2573598: Fix error: extra '; ' after member function definition [-Werror,-Wextra-semi] |
Wireshark code review |
|
| 20:45 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 21:05 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis |
buildbot-no-reply |
|
| 23:31 |
[Wireshark-commits] master fd4d009: ppp: fix conflict for hf field |
Wireshark code review |
|
| 23:32 |
[Wireshark-commits] master a08177b: HTTP: do not call g_path_get_basename with a NULL pointer |
Wireshark code review |
|
| February 27, 2017 |
|---|
| 00:52 |
[Wireshark-commits] master 513eed68: text2pcap: check return values of functions and use a single exit point. |
Wireshark code review |
|
| 11:41 |
[Wireshark-commits] master e8ff9f5: pluginifdemo: Adjust title texts |
Wireshark code review |
|
| 12:22 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 12:49 |
[Wireshark-commits] master 4b2a2eb: wslua: fix documentation of Struct.fromhex |
Wireshark code review |
|
| 12:50 |
[Wireshark-commits] master-2.2 6eaac3a: wslua: fix documentation of Struct.fromhex |
Wireshark code review |
|
| 12:51 |
[Wireshark-commits] master-2.0 971aaca: wslua: fix documentation of Struct.fromhex |
Wireshark code review |
|
| 12:53 |
[Wireshark-commits] master 220772d: text2pcap: fix -Wmacro-redefined warning |
Wireshark code review |
|
| 12:54 |
[Wireshark-commits] master d4cf571: Free radius dissector memory on shutdown |
Wireshark code review |
|
| 13:26 |
[Wireshark-commits] master a29fe9d: print_stream: free memory on exit. |
Wireshark code review |
|
| 13:27 |
[Wireshark-commits] master 8851c1c: extcap: remove leak in interface lists. |
Wireshark code review |
|
| 13:49 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 16.04 x64 |
buildbot-no-reply |
|
| 14:35 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 |
buildbot-no-reply |
|
| 14:43 |
[Wireshark-commits] buildbot failure in Wireshark 2.2 on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
| 19:43 |
[Wireshark-commits] master 8b8a3b8: Qt: Avoid null pointer dereference (CID 1401573) |
Wireshark code review |
|
| 21:22 |
[Wireshark-commits] master 59b672e: Return correct filter for get_hostlist_filter() |
Wireshark code review |
|
| February 28, 2017 |
|---|
| 00:20 |
[Wireshark-commits] master-2.0 4439e69: Return correct filter for get_hostlist_filter() |
Wireshark code review |
|
| 00:21 |
[Wireshark-commits] master-2.2 991f1b5: Return correct filter for get_hostlist_filter() |
Wireshark code review |
|
| 00:23 |
[Wireshark-commits] master 841531b: wiretap (nettl/pppdump): fix this statement may fall through [-Werror=implicit-fallthrough=] found by gcc7 |
Wireshark code review |
|
| 00:30 |
[Wireshark-commits] buildbot failure in Wireshark 2.0 on OSX 10.6 x86 |
buildbot-no-reply |
|
| 05:22 |
[Wireshark-commits] master 4ef0fa2: Some ERF pseudo-headers have color instead of lctr value |
Wireshark code review |
|
| 05:24 |
[Wireshark-commits] master 606f941: RSVDv2 support - 2nd stage |
Wireshark code review |
|
| 05:25 |
[Wireshark-commits] master 5c6f633: androiddump: Use only non-blocking connect() instead of the socket |
Wireshark code review |
|
| 06:11 |
[Wireshark-commits] master 2534ec4: sharkd: support for rtp tap. |
Wireshark code review |
|
| 06:41 |
[Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 |
buildbot-no-reply |
|
| 07:28 |
[Wireshark-commits] master 311b1ee: IEEE 802.11: Handle Atheros padding |
Wireshark code review |
|
| 11:42 |
[Wireshark-commits] master 26e62df: Qt: Fix -Wshorten-64-to-32 warnings |
Wireshark code review |
|
| 14:57 |
[Wireshark-commits] master 146b6b8: text2pcap: free memory on exit. |
Wireshark code review |
|
| 19:03 |
[Wireshark-commits] master 77d309c: radius: fix final memleak due to malformed dictionary |
Wireshark code review |
|
| 19:05 |
[Wireshark-commits] master 87b7242: radius: fix memleaks of value_string |
Wireshark code review |
|
| 19:06 |
[Wireshark-commits] master 3c6900f: radius: fix use-after-free after recent memleak fixes |
Wireshark code review |
|
| 19:36 |
[Wireshark-commits] master 82b2d8b: Expand a comment. |
Wireshark code review |
|
| 20:48 |
[Wireshark-commits] buildbot failure in Wireshark (development) on Windows Server 2012 R2 x64 |
buildbot-no-reply |
|
