Wireshark-commits: [Wireshark-commits] master a08177b: HTTP: do not call g_path_get_basename with a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 26 Feb 2017 23:31:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a08177b00bd07e77baa9db97bd731cb1df9173a8
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a08177b by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    HTTP: do not call g_path_get_basename with a NULL pointer
    
    If the HTTP request was not found / captured, the request_uri pointer in
    conversation data is set to NULL. Do not call g_path_get_basename in that case.
    
    Bug: 13441
    Change-Id: I86eef2072ad4932e8e415580e3144d1d95796c4f
    Reviewed-on: https://code.wireshark.org/review/20289
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  fd4d009   ppp: fix conflict for hf field
    adds  a08177b   HTTP: do not call g_path_get_basename with a NULL pointer


Summary of changes:
 epan/dissectors/packet-http.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)