Wireshark-commits: [Wireshark-commits] master 46ae4ac: RSVD TUNNEL_SCSI bugfix: SCSI payload is not
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=46ae4acf2d61b900d6db9ed05a214c5d756e3623
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
46ae4ac by Volodymyr Khomenko (Volodymyr_Khomenko@xxxxxxxxxxxx):
RSVD TUNNEL_SCSI bugfix: SCSI payload is not dissected for request packets
For SCSI packets tunnelled via RSVD, the logic of
SCSI Payload dissection should be:
-For SCSI IN transfer type (DataIn=1), display SCSI Payload of reply packet only.
-For SCSI OUT transfer type (DataOut=0), display SCSI Payload of request packet only.
-For non-data transfer type (DataIn=2) don't display SCSI payload even if DataBuffer is non-empty.
Minor fix: display RSVD DataBuffer BEFORE SCSI Payload in response packets.
If SCSI dissector failed (malformad packet), binary DataBuffer blob
will be still displayed in SVHDX_TUNNEL_SCSI_RESPONSE subtree.
Bug: 13403
Change-Id: Ia4fec817ae30799b763ae9d96c312fb7771d1618
Reviewed-on: https://code.wireshark.org/review/20089
Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Actions performed:
from 67d8830 wiretap: add open_routines cleanup function.
adds 46ae4ac RSVD TUNNEL_SCSI bugfix: SCSI payload is not dissected for request packets
Summary of changes:
epan/dissectors/packet-rsvd.c | 63 ++++++++++++++++++++++++++---------------
1 file changed, 40 insertions(+), 23 deletions(-)