Wireshark-commits: [Wireshark-commits] master fcc9cf2: proto: ensure that length is set for proto_t
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 18 Feb 2017 14:22:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fcc9cf2e454be68348f19cb4416702a208da5fb3
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fcc9cf2 by Peter Wu (peter@xxxxxxxxxxxxx):

    proto: ensure that length is set for proto_tree_add_item_new_ret_length
    
    A user reported that the TNS dissector would show "Malformed Packet" in
    the Info column in Qt. The actual packet details and Expert Info dialog
    however had no trace of the issue.
    
    It turns out that proto_tree_add_item_new_ret_length did not correctly
    set the length. Test case (based on pcap from SampleCaptures wiki):
    
        tshark -r TNS_Oracle1.pcap -w 19.pcap -Y frame.number==19
        tshark -r 19.pcap -Y tcp
    
    Change-Id: I82cb1ccbc7c3b33d2bcdb22f89a1754c1a4575e7
    Fixes: v2.1.0rc0-1394-gc67c6e8f30 ("Add routines to add an item and return the item's real length.")
    Reviewed-on: https://code.wireshark.org/review/20098
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jörg Mayer <jmayer@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  64d0133   plugins: free list on cleanup.
    adds  fcc9cf2   proto: ensure that length is set for proto_tree_add_item_new_ret_length


Summary of changes:
 epan/proto.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)