Wireshark-commits: [Wireshark-commits] master 420b9e0: ssl-utils: add length validation for SNI ext
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 6 Feb 2017 21:37:16 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=420b9e061e018cfd3d8799e16ebcfef347f0d528
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

420b9e0 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl-utils: add length validation for SNI extension
    
    Add copy of the definition in a comment, remove check for empty
    extension such that export info can be added if the extension is empty.
    Remove check for empty HostName, this cannot happen (and is caught by
    ssl_add_vector).
    
    Change-Id: Ie63b97e89dc7254f159abb338b52f5f894a8564d
    Reviewed-on: https://code.wireshark.org/review/19939
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  6c1d140   ssl-utils: add length validation for Cookie extension
    adds  420b9e0   ssl-utils: add length validation for SNI extension


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   64 ++++++++++++++++++++++--------------
 1 file changed, 39 insertions(+), 25 deletions(-)