Wireshark-commits: [Wireshark-commits] master bd9afdd: Reduce number of fwrite when writing pcap-ng
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 24 Feb 2017 04:43:18 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bd9afdddfe45b4c9c6e966df7264d12cdfd85f42
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bd9afdd by AndersBroman (anders.broman@xxxxxxxxxxxx):

    Reduce number of fwrite when writing pcap-ng EPB.
    
    According to callgrind with the patch dumping 3000 pakets the number of
    calls to write_to_file is reduced from 11541 to 9000 reducing the number
    of lr from 4 681 518 to 4 314 101.
    
    If the buffer holding the packet was guaranteed to be padded to 32 bit
    boundary the code could be simplified and if there was space "in front"
    for the packet header it would be even better.
    
    Change-Id: Ie991c05fa9d831ee4d703bd47b8123f2b1f83277
    Reviewed-on: https://code.wireshark.org/review/20256
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d347a60   Make MIPv6 options into a dissector table.
    adds  bd9afdd   Reduce number of fwrite when writing pcap-ng EPB.


Summary of changes:
 writecap/pcapio.c |   27 +++++++++++++++++++++++++--
 1 file changed, 25 insertions(+), 2 deletions(-)