Wireshark-commits: [Wireshark-commits] master 658253b: (D)TLS: simplify SignatureAndHashAlgorithm d
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 6 Feb 2017 21:31:00 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=658253ba34e569313f8fec0d2e4ed7367501c7a3
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

658253b by Peter Wu (peter@xxxxxxxxxxxxx):

    (D)TLS: simplify SignatureAndHashAlgorithm dissection
    
    Merge the length parsing into the SignatureAndHashAlgorithm vector
    parsing. Remove extra expert info which are replaced by the generic
    ones.
    
    Tested with a mutated pcap where the signature length field is off by
    one (too large = expert error, too small = expert warning, as expected).
    
    Change-Id: I43350352ae00eb42bbe5c2ee81289fb592b88f86
    Reviewed-on: https://code.wireshark.org/review/19933
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  4623b05   ssl-utils: refactor "length" parameter into "offset_end" for extensions
    adds  658253b   (D)TLS: simplify SignatureAndHashAlgorithm dissection


Summary of changes:
 epan/dissectors/packet-dtls.c      |    2 +-
 epan/dissectors/packet-ssl-utils.c |   87 +++++++++++++-----------------------
 epan/dissectors/packet-ssl-utils.h |   17 ++-----
 epan/dissectors/packet-ssl.c       |    2 +-
 4 files changed, 36 insertions(+), 72 deletions(-)