Wireshark-commits: [Wireshark-commits] master f3d52cb: Bugfix for extcap fileselect functionality,
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 26 Feb 2017 09:23:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f3d52cb534c67df8a811578d9387c41c05b714dd
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f3d52cb by Kim Bäckström (kim.backstrom@xxxxxxxxx):

    Bugfix for extcap fileselect functionality, start button in extcap options dialog wouldn't
    get enabled if the user had selected a file (and mustexist=true wasn't specified).
    
    This commit also contains minor fixes to doc/README.extcap, it's now more aligned to the
    actual implementation.
    
    Added example usage of fileselect, radio and multiselect to doc/extcap_example.py.
    
    Change-Id: Ibfe40a35a26f49322fbe64c0594506a2163f7e20
    Reviewed-on: https://code.wireshark.org/review/20274
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  9782d55   plugin_if(.h): fix commas at the end of enumerator lists are a C++11 extension [-Wc++11-extensions]
    adds  f3d52cb   Bugfix for extcap fileselect functionality, start button in extcap options dialog wouldn't get enabled if the user had selected a file (and mustexist=true wasn't specified).


Summary of changes:
 doc/README.extcap              |    8 ++++----
 doc/extcap_example.py          |    9 +++++++++
 ui/qt/extcap_argument_file.cpp |    4 +++-
 3 files changed, 16 insertions(+), 5 deletions(-)