Wireshark-commits: [Wireshark-commits] master b659c76: TLS13: fix length of Finished message
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 11 Feb 2017 00:11:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b659c76c320de2d66c369f88d400a98aeb56d2d7
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b659c76 by Peter Wu (peter@xxxxxxxxxxxxx):

    TLS13: fix length of Finished message
    
    Select the full message instead of just the first 12 bytes (as was the
    case in previous TLS versions. No check is added since it is too much
    work for little gain (it would require looking up the hash length for
    the cipher suite).
    
    Change-Id: Iea13d5abe6a7e55b04fabacfa8919a02acd8517d
    Reviewed-on: https://code.wireshark.org/review/20011
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  8136258   ssl-utils: add length validation to CertificateRequest
    adds  b659c76   TLS13: fix length of Finished message


Summary of changes:
 epan/dissectors/packet-dtls.c      |    2 +-
 epan/dissectors/packet-ssl-utils.c |   10 ++++++++--
 epan/dissectors/packet-ssl-utils.h |    2 +-
 epan/dissectors/packet-ssl.c       |    2 +-
 4 files changed, 11 insertions(+), 5 deletions(-)