Wireshark-commits: [Wireshark-commits] master 59b672e: Return correct filter for get_hostlist_filte
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 27 Feb 2017 21:21:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=59b672e5907d272ea5bd5ef571b03e004d07705a
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

59b672e by Jakub Zawadzki (darkjames-ws@xxxxxxxxxxxx):

    Return correct filter for get_hostlist_filter()
    
    It was returning (ip.src == ... && <protocol>.port == ...).
    
    Now, I think correctly returns (ip.addr == ... && <protocol>.port == ...)
    
    Change-Id: I242e13c0c79c2222e2b27fc2f9ee348b89d21ec1
    Reviewed-on: https://code.wireshark.org/review/20281
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  8b8a3b8   Qt: Avoid null pointer dereference (CID 1401573)
    adds  59b672e   Return correct filter for get_hostlist_filter()


Summary of changes:
 epan/dissectors/packet-sctp.c |   17 +++++++++++++++--
 epan/dissectors/packet-tcp.c  |   16 +++++++++++++++-
 epan/dissectors/packet-udp.c  |   17 ++++++++++++++++-
 3 files changed, 46 insertions(+), 4 deletions(-)