Wireshark-commits: [Wireshark-commits] master bb1450b: ssl, dtls: fix wrong expert info for overly
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 15 Feb 2017 12:20:10 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb1450b017226b0da892c7c3ebba0fe1621e38d9
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bb1450b by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl,dtls: fix wrong expert info for overly large records
    
    The plaintext length is limited to 2^14, but the actual record length
    (TLSCiphertext) may be larger due to expansion from compression and the
    cipher (like AEAD auth tags). The wrong check led to false expert infos.
    
    Change-Id: I3a56f1b0af05ecc1d97c4f1f0bcf35ff4d0fad42
    Fixes: v2.3.0rc0-1584-gff0371e898 ("ssl,dtls: add expert info for overly large record lengths")
    Reviewed-on: https://code.wireshark.org/review/20099
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  efcb5c0   Display 4 octets SDVL with 3 bits in ROHC
    adds  bb1450b   ssl,dtls: fix wrong expert info for overly large records


Summary of changes:
 epan/dissectors/packet-dtls.c      |    8 +++-----
 epan/dissectors/packet-ssl-utils.c |   23 +++++++++++++++++++++++
 epan/dissectors/packet-ssl-utils.h |    7 ++++++-
 epan/dissectors/packet-ssl.c       |    8 +++-----
 4 files changed, 35 insertions(+), 11 deletions(-)