Wireshark-commits: [Wireshark-commits] master 989b9d5: ssl: fix misdetection of HelloRequest handsh
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 16 Feb 2017 05:12:07 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=989b9d51883467024d8d3fa546916d9f6cad5e59
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

989b9d5 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl: fix misdetection of HelloRequest handshake message
    
    The encrypted "Finished" message was wrongly decoded as two
    "HelloRequest" messages due to the presence of GCM nonce.
    
    Bug: 10235
    Change-Id: I44f9bb5d927ac0d3c604e4125034cd34981d3943
    Reviewed-on: https://code.wireshark.org/review/20119
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d718b1d   Qt: Preserve pane sizes when changing profile
    adds  989b9d5   ssl: fix misdetection of HelloRequest handshake message


Summary of changes:
 epan/dissectors/packet-ssl.c |   31 ++++++++++++++++++++-----------
 1 file changed, 20 insertions(+), 11 deletions(-)