Wireshark-commits: [Wireshark-commits] master 1089211: SNMP: duplicate dynamic members of snmp_ue_a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 Feb 2017 13:20:17 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1089211c0b0aca7d95b4f54ca0e61d070555e896
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1089211 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    SNMP: duplicate dynamic members of snmp_ue_assoc_t structure in localize_ue()
    
    Otherwise you can end up freeing twice the same memory blocks
    (from localized_ues and unlocalized_ues lists)
    
    Bug: 13420
    Change-Id: I7e6f1f8d740b0e5ffca851f3f5b1928a7686c069
    Reviewed-on: https://code.wireshark.org/review/20190
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  e2e4415   Add some glib functions not available in older glibs
    adds  1089211   SNMP: duplicate dynamic members of snmp_ue_assoc_t structure in localize_ue()


Summary of changes:
 epan/dissectors/asn1/snmp/packet-snmp-template.c |    5 +++++
 epan/dissectors/packet-snmp.c                    |   11 ++++++++---
 2 files changed, 13 insertions(+), 3 deletions(-)